Date:   Fri, 10 Mar 2023 13:05:36 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Eric Auger <eric.auger@redhat.com>
Cc:     Nicolin Chen <nicolinc@nvidia.com>, robin.murphy@arm.com,
        will@kernel.org, kevin.tian@intel.com, baolu.lu@linux.intel.com,
        joro@8bytes.org, shameerali.kolothum.thodi@huawei.com,
        jean-philippe@linaro.org, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 05/14] iommu/arm-smmu-v3: Remove ARM_SMMU_DOMAIN_NESTED
Message-ID: <ZAtjYFMio7t66KWy@nvidia.com>
References: <cover.1678348754.git.nicolinc@nvidia.com>
 <c62c9405ff31ab3c97a9165ff710dce68217fe22.1678348754.git.nicolinc@nvidia.com>
 <1c18d68c-a20d-0f6d-4bf7-56f40557d151@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1c18d68c-a20d-0f6d-4bf7-56f40557d151@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4OmxGkFlkzrzQNTGoDl412Pa3JTkLKbjJ31hmAKy5T5lUogIDl7iyoKK557B?=
 =?us-ascii?Q?us0wI06KJt384W2elo3OK5ar5FdCwXQUUk6fQCnFCioUFm0KHVy2bHArG0cI?=
 =?us-ascii?Q?ujDcXeg+a18cseJ+uW2B2i/1SYMjPLmRFVCYeL31rHOjc1zcJaaTfDnaz42+?=
 =?us-ascii?Q?Nd8lA+SzMlmdc9Fh1JwO0Q1RZHTdChD7SlVyDXQxGxs63t7f97VN56PzFxaE?=
 =?us-ascii?Q?WPsT2I1w0rnrbdVURb5zmQgwTFSfszWysMuUXvx+jCpgBOAb9p96H7uJwGpa?=
 =?us-ascii?Q?h+FOo43o0GEE/Cw7wgLLIlfkEW2sY4iJ7suy5HSHQY494DMvlCghtXxgF7Be?=
 =?us-ascii?Q?mmOeDPf2UzXf1J6ROjMN8f5ulWFLBlo+ccKMhQ2xZKJDkGbPTQUXGEJff9x9?=
 =?us-ascii?Q?k9W9YQddTKFAjk9wfIGpNeu6lEYDEbuF7iIrdaulXnqMoTulHnqSW5oQHCBQ?=
 =?us-ascii?Q?9qyNW4mguxj+nzD+volAyezd9jty2cW+/GpIXnfVxOKO51fWtJCgAQd80dBN?=
 =?us-ascii?Q?Y5PHbMq+Z7OyJmENIDXZB766HoKLq8/23IS28AwQW1+dC2lRZPeKJZpjiIiX?=
 =?us-ascii?Q?uMfswOe6jBZ+uiYhoUHsE8vDVD8oOJmE/G+RgGYYNvP7UDu2exlSa8mqu1xu?=
 =?us-ascii?Q?dp3T4LStgxFObCKaZNAE8Ix31draomN7ChebbWCXv2e70EVYsA3jAZkCrbPb?=
 =?us-ascii?Q?8r4UAxEXBfDmEqN86NEKHeZQdhFv/Cd/RvEZgK0iKJ1tH2MH4R5yRd1FmMnX?=
 =?us-ascii?Q?EOTI+n7mhsZpwycBU+m/rA5ujbKYaPM9S8EQbtWzbnFXXdGM6eFQHM4xpb9r?=
 =?us-ascii?Q?X8qBvYiHM5CCAg/R8t2xt5h6TsCvz3ZLico7dPNiqp2zGNIU1a8ICje4d7s2?=
 =?us-ascii?Q?r8xAH4Gp1lJ3RwGxgs+xv/DQfoGS4moAO3pKhpS2jfP2W9EHf7hi7KQUDJ3A?=
 =?us-ascii?Q?cHttfcepLDPR3HKr+734vW1adoyLyMC7PhcYWpPHIPtvKaIZd/EvVoufnQOF?=
 =?us-ascii?Q?FcY9S+GRK7fGKliPKwscIwM6K8DPKA2L2wupLPUDTc7Piv95qeR9YH9FSpHw?=
 =?us-ascii?Q?O6qnkP3feKkWXu23MEBvBtia3Ljm+Nh1Ee5TBV0twsKEci/mi8WJNCt/jhED?=
 =?us-ascii?Q?0gfNETufo5S3rwS+U00JOzt5ZusimGdMH5hxT84cSnMCvMiCgsOXvquYDNQU?=
 =?us-ascii?Q?z8zem/ACepgRsGM6zYAcqgg0UtbN5s4Yvs6QdcrcdQlxwytLWYHMYmMGTlI+?=
 =?us-ascii?Q?cbUcM5kG9qnG6OSPtL4h3VWplqXB25wKuNAFgErBCFhplePZQnl0v+yxlkq/?=
 =?us-ascii?Q?ZamebVb/o6kme72G6yK9Vwwp3pSP7dGhutJTIhGory90WdFPy4PQqqBS5YIL?=
 =?us-ascii?Q?Oh5JNSOdE7Ljezq3HEe7cp+MXv4Z0eqcmh9LvATNfvv7iADB/IvcSB6T67h5?=
 =?us-ascii?Q?zrto+GidJKg7kg249nwA0aOS+mupZYX15KzICKG5h4Ep/QtfnVc7n9AdKNs6?=
 =?us-ascii?Q?/Yz2hZVcE18QHRVmvkkOYH4EwKfkDMctDz+TJnzHNORVJ5lGUW51UQEksGAO?=
 =?us-ascii?Q?d4RZJx5X++pzBu322qk/UcucXOg0RbInDmOIr06u?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5dd4303-9df3-4a2b-2787-08db2189ac82
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 17:05:39.3378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2yzYd83YoCxky11EWxJ3s8/PaWauczQ3IXiNaJwV17qhYqOZZc4jDFMZkVayeVSk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6393
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 05:39:22PM +0100, Eric Auger wrote:

> > Also drop the unused arm_smmu_enable_nesting(). One following patche will
> > configure the correct smmu_domain->stage.
> >
> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > ---
> >  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 18 ------------------
> >  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h |  1 -
> If you go this way you may also remove it from arm/arm-smmu/arm-smmu.c.
> Then if I am not wrong no other driver does implement enable_nesting cb.
> Shouldn't we also remove it and fellow iommu_enable_nesting()?

Yes, lets just put this patch in the series please:

https://lore.kernel.org/kvm/0-v1-0093c9b0e345+19-vfio_no_nesting_jgg@nvidia.com/

Jason