Message-ID: <791bbd24-3146-a5ce-db7d-ff0b95a08e6b@nvidia.com>
Date:   Fri, 10 Mar 2023 09:22:16 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH] hte: Use of_property_present() for testing DT property
 presence
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        timestamp@lists.linux.dev
References: <20230310144706.1542365-1-robh@kernel.org>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20230310144706.1542365-1-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTYvU2RRUmlPS2tiLzVyS2hESmpVVDdGdnRHN1UxdHdYU1BMZEx0MDFERHkz?=
 =?utf-8?B?SkVKZnk3OTVlY1VqNDIrV0lsOEs1THBHZHY3d2ZSSWJpMGV2ZGNGZjVFZzND?=
 =?utf-8?B?bUJ6Vzk2YzF3WkVRRVVtNDZhdmNGWHE1V3MvVEE0ZXBwcnNOR2tZc2UxY0pt?=
 =?utf-8?B?b1JZci9xRkJRWVBoVnVDOXY4RXF0Sm45cjB4MHV6eGNBaGJKMk55WU1URWlC?=
 =?utf-8?B?Mjc2eWduakNwMnZqYXZWdkpzbWRQcDJSMkxqN0I2WUkrZUt2TWxya0tLTWpu?=
 =?utf-8?B?NEJ0NzB1ZEo5M0hNNFFzdTh5VWVpdnAzR2o3eUh4Ymlxc0swRXpaL2hrdnRM?=
 =?utf-8?B?eWs3QUpBU2tMR2FxZU4ydzVhdlhUN3ZLRnhuNi94WUdseVN3bzdlaXJUTmQ0?=
 =?utf-8?B?MzlEUnVxb3VHMzdkY3YwSUJQTXBCVG5OMTlqTFo1a3RBSlNZMkg2b0NNVk1X?=
 =?utf-8?B?dndmZ0EzYnkvR0NEU0FRODVwNERUdjRrT2FKa0tqaW8yaVdMK3o0bHUzOUNR?=
 =?utf-8?B?RFRwTkdlUWpDK1BoNVVRYkRjRXZzYnFpVUlPRzU2aHg0c2V0eDdlVmplMDF4?=
 =?utf-8?B?UkZFWGxsUHo2akV1MkVWUlBySzNUMTAwaTFtZ3pOTUJpOW5USzk3SFdNem40?=
 =?utf-8?B?c25hR0QzbmhheW9vNTBLaXE5bHp2ZkJuOGhjWTI3dnFGbTlGS3N2ams5SHhC?=
 =?utf-8?B?TnVGRXp2V3p3anRSVnNzS1Y2YUl5Wlp6RVgra1hqLzVDL0lXaS9PaG1vTElF?=
 =?utf-8?B?TDlXNUFWZC9hNnlGcE1aUXVqRU9MNkJkY3FseGJvVHdONUc3QnplSVpjMzZT?=
 =?utf-8?B?ZXVUZGE3K0dKcVJDU2RxTWVGRGJkUmpnVTNuQ1FZVDRHT0hDR0dmWXFCbk1N?=
 =?utf-8?B?NDR5czJLZWZ6M3FPeFVzRkpNSHlOUjFFU29QZldjWmdjRUZOWkVjbFZQZ2di?=
 =?utf-8?B?Mkxxa25kRVpVa0hIWU1IOWc2b2tmbklObFZPb0FXV2FjSno5QU9uV0hBd0ZU?=
 =?utf-8?B?bVBRUDdidU1lM3hmL3VCck1NZi9SdVRldzJoUzFNSTViNzdldTZ2ZGRjcE9U?=
 =?utf-8?B?YWIrNWFqUkJLanVOdlBhRGhJUkdmWWZ3ME5zYjVIdHNlZlZXbE0rLzl5NU95?=
 =?utf-8?B?L1piRXVWZ1Z0TG9MR1ArRzZsUFRUSTZMK1NCbG5TU1Q3UGEwalZ4TGk2VWFm?=
 =?utf-8?B?eXNzdHduUSs3a0pOMmowZ3poRzlsVGJDQXQ1R2J4Nm5TY0VpeStKWHE3UDl2?=
 =?utf-8?B?dUZYb3ltdVlNdVMrYnJqZW9Vdi9tMC84aTZHeTlxbEtiQlNDa2k3L2pwcjVU?=
 =?utf-8?B?dDN1aFNMcXVPL0RrMXU5blJqL0l3YTVoNnUyVjkySlJPTUc5Q2kxMS93VEZ2?=
 =?utf-8?B?dldQWE9hS3J5emVJc0wwSEFQKzF3bGkvNmV6RWNjcmJTMHlzV1Q2RDAwSzNT?=
 =?utf-8?B?MFpJZzRtQkx6Z1FFWW1KT20yMFJsVGlJQnlWZXZraHI5RTE4dnNSSXdQeEhN?=
 =?utf-8?B?VHVYTlE2SytVMS9lMEVqVHFodERIVE1lM2VWMEd2UWYxZzVJYy85QkF5TDV6?=
 =?utf-8?B?emZCZlc2RzBHZGZkNEJDdkxHY01ZcitpN3l6OXoyM1lpTHM4QXhkejNKTlZK?=
 =?utf-8?B?aTNRNktqckd5RUFCMXJvaU9BdVY0L21nallvL0hrTGNOY28wY1BXc1N1NmhP?=
 =?utf-8?B?TTNFdEtmYUlxbDYreTVUbnhGK0hHZndkWm1GcTNTcmZoRVJreE9uczZiaW9U?=
 =?utf-8?B?azZiVmx5MmVIYWRjOU1sbGcxVFVWdExodFRDbUREbERYYmRRTHFJWUtrSlNz?=
 =?utf-8?B?TE9zVUVpUkZSbGF3VUV3amFzN3BBdmZ1UFFiWEM0QitUV05KUmNwRzQ4VTEv?=
 =?utf-8?B?UExwamF4TUZxZEQzQ0U1Uk02WFBnL0Y2T0RBWGFBL2xSK3phYmJPbVhKdmxv?=
 =?utf-8?B?TERlSnNWOVpvbXRHd0M1bDI3ZmovVkRvYi9wMkh4OGRqT0dIUVp2dklQWVov?=
 =?utf-8?B?Y3lYK2w2ek51aGNJdXFyZkl5RFBmWUoyUU83dHZVNnROZ0FyODB6c3FLQ2VI?=
 =?utf-8?B?VXpCVHYzeG5nQVQvMVlNZXlxWTRPekV2MVp5OVVqZVhpTU01Rmc1ZjVlS1kr?=
 =?utf-8?Q?xEvWExOro32JzIr5hV5KU2IFt?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d226e1c5-c188-4e6d-12f3-08db218c00f9
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 17:22:20.0841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q+Pfcr77X1E60lTi+G//PHsgbAgtF+g4PAh13NHkAC4nieBBHhV4MLFhatvOo235lwmwN8mdj080JCqoWCBDkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7073
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/10/23 6:47 AM, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/hte/hte.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Dipen Patel <dipenp@nvidia.com>