Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB9F7C6FD19 for ; Fri, 10 Mar 2023 18:50:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230508AbjCJSul (ORCPT ); Fri, 10 Mar 2023 13:50:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjCJSui (ORCPT ); Fri, 10 Mar 2023 13:50:38 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 187BC125D92 for ; Fri, 10 Mar 2023 10:50:38 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pahp2-0008TP-84; Fri, 10 Mar 2023 19:50:32 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pahp0-003EbR-M2; Fri, 10 Mar 2023 19:50:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pahoz-003rf2-BX; Fri, 10 Mar 2023 19:50:29 +0100 Date: Fri, 10 Mar 2023 19:50:28 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Benson Leung Cc: Guenter Roeck , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, chrome-platform@lists.linux.dev Subject: Re: [PATCH 2/4] pwm: cros-ec: Explicitly set .polarity in .get_state() Message-ID: <20230310185028.z2rewz3467fvs5a3@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> <20230228135508.1798428-3-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g2zqdfjbor4id76k" Content-Disposition: inline In-Reply-To: <20230228135508.1798428-3-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --g2zqdfjbor4id76k Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2023 at 02:55:06PM +0100, Uwe Kleine-K=F6nig wrote: > The driver only supports normal polarity. Complete the implementation of > .get_state() by setting .polarity accordingly. >=20 > Signed-off-by: Uwe Kleine-K=F6nig I think we should apply this patch as a fix to prevent similar failures as reported for the meson driver. To justify that: Fixes: 1f0d3bb02785 ("pwm: Add ChromeOS EC PWM driver") Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --g2zqdfjbor4id76k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmQLe/AACgkQwfwUeK3K 7AkkUAf9Em3mJsgoxTz/iBgebzx6c8aTWGyQgK+GvgV6dNlY+O5UNPRHbIyBzGZe bmUqERDjuAkds3gShpEsb6W+pB+Zbl2a2qj94aoCCugX2GO6jxmdISnIsIMcUQuh nZxzx+CtNZKc1meGqSgOnScjeDArFR88cvRueEHSJHhATyl62Fc+hM3MLYxq8/U6 Q1kTi1d8ZDIt7bnNb0mCUuuQ8/l+LNzeCZW2wlzoBnBF9z8KDS8ogWqBxTe6YEqS rRUiUXKDnXDep2lfIf9Qd+53BNos38YqsafdDFRbpWBeiXf9vZxjfUoq6uh+VomH XiJins19aj3WBhfJzWrQyUaaXH8Y8Q== =VYcZ -----END PGP SIGNATURE----- --g2zqdfjbor4id76k--