Message-ID: <e15a6fe7-42e1-cb9d-37b7-d350d8168eb7@intel.com>
Date:   Fri, 10 Mar 2023 11:57:48 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.2
Subject: Re: [PATCH v2 05/18] x86/resctrl: Allow RMID allocation to be scoped
 by CLOSID
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>
References: <20230113175459.14825-1-james.morse@arm.com>
 <20230113175459.14825-6-james.morse@arm.com>
 <2ad21ffe-6019-eb34-a0b3-2c9d26799269@intel.com>
 <753cd447-24a8-0dd8-6f35-9ad75ba619c5@arm.com>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <753cd447-24a8-0dd8-6f35-9ad75ba619c5@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWZadUROQzRvZ3JldEJoZTRiNzZSenhYZDNvaldiZzNjL0w5VEVEczBkZHB3?=
 =?utf-8?B?SElYWFZPV2lVSEhOaGVHZUJEZ2pSYUc3blg0WjdaanFIS0RxTkJOOEpPT29m?=
 =?utf-8?B?c0NZNC9ieFN2M25NOUFjeG5rZkoxQ3Y3UnhQMWhyZGFmams2Q2MyakZuWWx1?=
 =?utf-8?B?R2RKMlp1ZVJqM2tPQ2RlbXZsL0tKZDg4Smx0YWdjZFM5Wm4wT2NGN013cjNo?=
 =?utf-8?B?ekpvTjU5K3VHOXdDK3hPK2trWkQ4ZVc3Q052M1JVZStMajd0RWdHN3F1a0xR?=
 =?utf-8?B?RE83NVVmWE1wNFlTSVcrNzE1ZzF2YXVJTVFYd2wzK1EzUlVRTVJHMUZ4VUJu?=
 =?utf-8?B?Sm1ZNXI1WXJTbTE5N0Z0MGIvb0hrcU5sSXp1L1RmWjZDcEpQeVZzY1IrN0Uw?=
 =?utf-8?B?WVhhRnpvT0NqUzZneTVJaTVhOU5BRU94cXhUbTMvcHA3Ull1Y1BlaVVoTTha?=
 =?utf-8?B?V3BJODBDTnhpUlNrQkVwek9EaGRuZTdmUU5TRHV5ZmVIMVNkUjFRVlo2RXJE?=
 =?utf-8?B?S1B6R2tmbFJHMVhVVU9SaGtoV0FxMFJYekw3WUVHMHdETnF0bEtKL3FBVnBx?=
 =?utf-8?B?S3FQVWdZQS9NV0IzU0ZBWFdwVDBwa2tzRVRQR3ByL1gzak1TVnNxRGhUcHRJ?=
 =?utf-8?B?M2xPdmEybC9hZ0p3M3NIcDVieHErWDZTb3Z6UitxKzBUdTFaWkcrSW0yMDVq?=
 =?utf-8?B?SFc2N3lQTEJtT3ZPb05tVXV4by9meWtYWHhyUmFVSEwzWmFYbUt1ZGRONzJr?=
 =?utf-8?B?VVQyL284YXJPbE13UmdrL25LSlNOR0s3UmJSbXIvTGlCaE53N04yS3NKSXN3?=
 =?utf-8?B?aEt0eHVzNWg3Tks4SkR1QjVSajgvbUx2VW9mS0phWTl2czZIblB4YkJRT0VM?=
 =?utf-8?B?dGtOUjZGUERiMTR5OCswalhINUVoTGREZ05OL2J5M2RoUUlwZHFZWHdybFJT?=
 =?utf-8?B?UllmSW5ZWmV0MGdtZWJaYUpuN2N6RFBOTGc0cjdPL1F3QTh2VU9QK2Y5bUlu?=
 =?utf-8?B?VmxwMitJWEtSOFJNVHh2T21ScDY4bEx3Qmg4WUlGRTBodmJVYW9pZSsxTSt5?=
 =?utf-8?B?VUdTemgzZGpLMzB5TjA2NFV6d0EwVERpUDUyZndkbSt2NVdpbEdicjErNENm?=
 =?utf-8?B?ejNUTSt6d3B6Qzl6endQWW95eUx6cHZKV3RtaVFUc2VhSTB6a2VOMy82SWNu?=
 =?utf-8?B?cGlYVWJBYUE2eC8yUUhHeVZOZ2hmWmdzRGJ3Y3NtbG96WHBsT294b1hkUzUy?=
 =?utf-8?B?V1l1SDdxc2srV1Y4V0VxeHJLVjR2S01hV1BJMnRpaHpxUnBzdFVKdnZVaENr?=
 =?utf-8?B?K0NsY0hnb2RoU3EwcWRUZEtzRVY3ZUJEbGtmZ2RqbytWSVBGbDhuYWxQM0w5?=
 =?utf-8?B?akkrTWdxeE1jWm5MOWNEcW1sTWpYMHpRWmZpdWdBdTF0eGtMQ0pPRzZ5STZS?=
 =?utf-8?B?dmZjNXdmMFRvcExvWE5MQTkzNFg0N2YwNmZ5dFNtNWZYaEx4TStQckcyNTlz?=
 =?utf-8?B?ZWZOaDFnZ0JicUlDRERqQjZac3FoTzcxdTRrTUR3andwblgzc1NyZmxkNnNR?=
 =?utf-8?B?SFNKUHZTMkhsSmllSThWa2FiZTVPZnJydTVTOHh4em1FTHFKL3JiNmRXWEMx?=
 =?utf-8?B?MGo4ejlFaFB1NlU4V3k0Qk1nMlNMT2VpQnhEcEtGVzdEQVRCMk5vdHd6OFQz?=
 =?utf-8?B?OEs4dmNvWVJKakozejZCdk5jWU04dnlkMnord3kycFlQUzZUWDByeDVHeGI5?=
 =?utf-8?B?Ym02NWtZOUdSY2NYT1ovWURzZTlsaCt0Y0xPUlZXbDQ4SGZvUG15bWgxcmpZ?=
 =?utf-8?B?RWRCMnhhQzhTclppWkhzeFlmUjg5cFYvV3RILy9ETWRhZ2VvZTVFbGlKWlV0?=
 =?utf-8?B?Zk1xM1BIRmV3RUk5Q2JEZnFwak90RDhkcTlSL3gyMUhPNFNDRFRzNDdHWW0w?=
 =?utf-8?B?a3VpU2oxWjMwS2FKS0RyaDk5VHVCTXBtd21PMitpSXBZQm81T0JDcjMwdGN0?=
 =?utf-8?B?MS9iSElmU2dLU0ZKWkRib1JOV1NVU2Foc3VRNXlzdlhaTUxld3JrY0lqRGds?=
 =?utf-8?B?ZGRUNGFGaEh5SVZlcUc0RlBHK1NRZXEvaDFVWU9QemwrNk42MWpwLzl2ZW1k?=
 =?utf-8?B?U1AxMjByTGZPNTB2d1lHK1pTb0JhU2dubFJKT3lnVnZLT2s4MXFVV1JEb0Nn?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a8c163eb-08b3-43ea-9d8a-08db21a1baf2
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 19:57:51.6251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: obf/Rl/CGWgVfXnQtq4ecyB9lsjHhQoEKFV5j4vWrGjr5qxz1fTmhs54RWrocX6BdmdWBN/uKqbG8PFUCAZvTZ6ybvPICJfc9sdf6RZjo1E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6320
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 3/3/2023 10:34 AM, James Morse wrote:
> On 02/02/2023 23:45, Reinette Chatre wrote:
>> On 1/13/2023 9:54 AM, James Morse wrote:

...

>>>  /*
>>> - * As of now the RMIDs allocation is global.
>>> + * As of now the RMIDs allocation is the same in each domain.
> 
>> Could you please elaborate what is meant/intended with this change
>> (global vs per domain)? From the changelog a comment that RMID
>> allocation is the same in each resource group for MPAM may be
>> expected but per domain is not clear to me.
> 
> This is badly worded. It's referring to the limbo list management, while RMID=7 isn't
> unique on MPAM, the struct rmid_entry used in two domains will be the same because the
> CLOSID doesn't change. This means its still sufficient to move around the struct
> rmid_entry to manage the limbo list.
> 
> I think this had me confused because 'as of now' implies the RMID won't always be globally
> allocated, and MPAM has non-unique RMID/PMG values which are a different kind of global.
> 
> 
> I'll change this to read:
> /*
>  * For MPAM the RMID value is not unique, and has to be considered with
>  * the CLOSID. The (CLOSID, RMID) pair is allocated on all domains, which
>  * allows all domains to be managed by a single limbo list.
>  * Each domain also has a rmid_busy_llc to reduce the work of the limbo handler.
>  */
> 
> (seeing as the function doesn't touch rmid_budy_llc, or refer to it by name)
> 

Thank you. This is easier to understand.

Reinette