MIME-Version: 1.0
References: <20230310184201.1302232-1-ajye_huang@compal.corp-partner.google.com>
 <0456bd4e-cfee-b863-e02d-98084b5da0f6@linux.intel.com>
In-Reply-To: <0456bd4e-cfee-b863-e02d-98084b5da0f6@linux.intel.com>
From:   Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Date:   Sat, 11 Mar 2023 04:01:03 +0800
Message-ID: <CALprXBamM-M-YdyfX9dQHp_AQAovcqzL5H4rMPsZPXS426+VgA@mail.gmail.com>
Subject: Re: [PATCH v1] ASoC: Intel: sof_rt5682: Enable Bluetooth offload on adl_rt1019_rt5682
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Brent Lu <brent.lu@intel.com>,
        Yong Zhi <yong.zhi@intel.com>, dharageswari.r@intel.com,
        Vamshi Krishna <vamshi.krishna.gopal@intel.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        alsa-devel@alsa-project.org, Mac Chiang <mac.chiang@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Mar 11, 2023 at 2:48=E2=80=AFAM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> This sounds good, but if the intent is to have BT offload enabled across
> all ADL skews there are still misses, e.g.
>
> .name =3D "adl_mx98357_rt5682",
>
> Can we please try to add this BT offload in a more consistent manner, or
> add a comment when this is officially not planned/supported?

Hi Pierre,

The "sof-adl-rt1019-rt5682.tplg" for this "adl_rt1019_rt5682" sound
card also need to enable bt_offload, this one I will submit to SOF
later this weekend.
ex, topology: sof-adl-rt1019-rt5682: add bluetooth offload uses SSP2
link -- https://github.com/ajye-huang/sof/commit/09dcbc3cc1617df652944299c6=
3082f1936dea6e

To be more clear, I think we can add a comment in the commit message
for mention " The related "sof-adl-rt1019-rt5682.tplg" enabled the
bt_offload feature", is it ok?