Message-ID: <2d9fa4bf-dc59-26a3-10f7-69455e2fcf5e@intel.com>
Date:   Fri, 10 Mar 2023 21:10:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH bpf-next v2 0/3] xdp: recycle Page Pool backed skbs built
 from XDP frames
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
CC:     Jesper Dangaard Brouer <jbrouer@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        "Jesper Dangaard Brouer" <brouer@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Menglong Dong <imagedong@tencent.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>, bpf <bpf@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20230303133232.2546004-1-aleksander.lobakin@intel.com>
 <73b5076c-335b-c746-b227-0edd40435ef5@redhat.com>
 <CAADnVQJ-kWG0eL8n5r3zBeXYaXihaqMcNrOP9++QuqsnhYzL_Q@mail.gmail.com>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <CAADnVQJ-kWG0eL8n5r3zBeXYaXihaqMcNrOP9++QuqsnhYzL_Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VndibUltRGYveVFKMGxnRGljTHF5dHpsU0lUVlhHUXRQcitjOFgxL3FGVWlH?=
 =?utf-8?B?VGdTSTE4ZUYwNzcvczJSRFlnRkxpaG84K2orVnZ5OWYwb3FWWlorQi9mTmM2?=
 =?utf-8?B?MnMrcGU5Q0MyWVVaRTdXdjlUbFRoQlNUc2pMUEV0UTROSklWQjNnSGJnTWZ6?=
 =?utf-8?B?UXYyV1FhZ0NlRS8rMVh6QmF5MnZOOEZaekFoaDVZeXFIamVESVJEMm5KMTNy?=
 =?utf-8?B?Rzc3WEtQamdtalRYNERnNC92K09rRUxWbzlHRXRTOWY3YmtpeUNvL3VhczZJ?=
 =?utf-8?B?alNCWjZPQURmYk5rcUxYQkhFUmgvT1V4dG1WUFMwYzhEQXhlbHRGNC96S3Fa?=
 =?utf-8?B?MC9FNHA1bitZS2ZzN2dhRVdpSnFvSS9BWHdOclYvZUtzeThybVlkbkdRd3NI?=
 =?utf-8?B?Y3V3aHI5OFFxc3lzUnZoVzZqOENkV241WUFLRTM2OGYzZEN1Qi9ERmtrdU1i?=
 =?utf-8?B?TU9LTlJ2dk9OQlVTcGYvZHc5T3QvNHA1V2xxQXJoSDluOGpJSGFyczFiTTJK?=
 =?utf-8?B?eGZGZnUrRG4xWXRRcHNzcFJqOG5XcXhVUUh6Um4rU0hWdk93OVhsR0hzMnRK?=
 =?utf-8?B?MEVvcWtZWFdoTWFiZVg0bmRHWDFsL1FpZVN6dGIrYzF1aVhKcDZyYkx4YjM4?=
 =?utf-8?B?REREaEU2ZktLZ3dSZUlqS1pQYnIrQ1psZTc5dFhod29Ca1pLOUFRZW1uaFgr?=
 =?utf-8?B?TzJIdE43QTFOeXZmQjhjVlc5WFUrNVA3NndrOWszRzFJditHYm9IS2UwZG83?=
 =?utf-8?B?V2ZMSzkza1F4Z241ZE5RVVJsMXVYM3E4d0JtcmVDRTNkOThuOENQVlhCMjFT?=
 =?utf-8?B?eXhndVY0ZHlNMG1EdzRkenVGdU1Ka0F3VHB5U09raHBsRU43QTJqb054SHpa?=
 =?utf-8?B?QjBqdDBrMUJkck5xREc2ZU5teVVDYW9yNUpPb0VVMjd4L1N6OGZsbjI4YkFJ?=
 =?utf-8?B?Z0djb0wvTDFiRjByU0FFWkVhSkZkcFRXb3I2TDZxMVAxZDhGRXdleVVTSjlx?=
 =?utf-8?B?SmZiR3pSemw4SkxUcXFhVlhCUHBVZnB2MG4zMHIwMGpmK0Job3Iyb2RKVlNX?=
 =?utf-8?B?bGdhMkN4aTQvTndWa0hUT3Q0Szd0MUNoTFFXLzcySlVlTEJVRnpNVXRaK2JB?=
 =?utf-8?B?NEZwS3RiaUMxUkcycHVDdkhxU2d2c2loSHBiNDk4ZDEyajd6RVcwOTdpeE91?=
 =?utf-8?B?SDBVamgvRmEvMmo0ZlRrQjNZRUpMRjloR1VvTk5TOWtweTVMRjFiMEVDRWhJ?=
 =?utf-8?B?a282aWM2NDdXdTJLTzlibWdWS0RqdlNhYlJkQkxwZnNnQXBJZHBXSUtpaHov?=
 =?utf-8?B?V1dpTzlqMW83VzZUVHo2QUhzL1ZVb2JjNDc1K0VlY1IxQjNFYWJoTVJFU2Y2?=
 =?utf-8?B?YVE2SlQyeVJzK0tTaCttZ2NZM1JjWlljWHJVQlIya3FpVEwrSkJSRUN2QzR1?=
 =?utf-8?B?VUlaTHdnekRVSjAxcDFSRTYzKy9PVWw4RjRPVDZBNU91amhteGc0NzJQNEVq?=
 =?utf-8?B?NmFqVTA5eFFUNGFrbmw2Vm83c0xVRUlWeUNTNC9nRlRra1N4Y2pPT2FMN3ZE?=
 =?utf-8?B?RVBvWnVoMEo5OTNaOHY1ZzFlY3RydnZkMGdMeHA5RkpYUVhZYmlDSGdJTjFR?=
 =?utf-8?B?K3NsblBEZk5xOWFMblZPekR1dWE0NWVPdm5BMElsZHFMQkY1NkpTYnhRSExz?=
 =?utf-8?B?ZSszbnNHSzZTVGZkUEFrRG80SEF2NlI0bm4yY21FSXpBRlYyaUxUbTY5dWQ4?=
 =?utf-8?B?TC9DTTM5bHArQUhVVkkrTC84ald4VGFkNDNrZmJ1UFRYRkY0WkZ0T0lrT0dm?=
 =?utf-8?B?TTV0Rm9uSUtCdHNHMVFCa29hV2gyNlNUdThCQVkzdlZlUUNiekdrRFIwcnUv?=
 =?utf-8?B?R1ZUcDd3NU93UExnSzJUWEVsTkVkUW9hNmIrakk2M2VZTkk4Nng4QUYzbkFK?=
 =?utf-8?B?bzRJN3p1NnA4cUlIL29jZ1Uvc1o4SFJhak5FK3M1aVZ2cVFMSHNSMEM2TjI4?=
 =?utf-8?B?VGcrcXY3L0dmdCsvcEpCNTE2OHZITDRRYS9NK2VycnJ6S29aMTdFQTVDRjBv?=
 =?utf-8?B?T2g4R1NCZjZXVHQyNTNvZ3p5KytDR3ZtRzc0Z01RM29jakIyeE5WVFFYK1BM?=
 =?utf-8?B?Q3hjeHpwN2ErOWdFaDkyVXZyN0NEYjJuTVExWmYrTmc5V2lBcDVzbHFYeEFF?=
 =?utf-8?Q?bCbhyZqm40FHkFZC+c3XFNo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a8f3372-85ea-4a3b-37ef-08db21a3982a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 20:11:12.3252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qp4QTC4qF4wWvu0+UMY5cX8We11eKs/FjIrZ6WDXQAhYNkXB0IyW/jD3n8cTwa4nQNmVAQ0kg4UFNxOKIPUlW2HLnRyxcwmJLW4AehL0Yow=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6147
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Fri, 10 Mar 2023 10:33:39 -0800

> FYI
> 
> test_xdp_do_redirect:FAIL:pkt_count_zero unexpected pkt_count_zero:
> actual 9936 != expected 2
> 
> see CI results.
> It's a submitter job to monitor test results.

Yeah I saw it. Just for some reason I thought it's some CI problems,
like "what could possibly go wrong?" :clownface: Sorry >_<

The test assumes that only dropped pages get recycled, while this series
actually implements recycling for redirected ones as well. I'll dig into
this and adjust it on Monday. The code itself is fine :D

Thanks,
Olek