From:   Mike Christie <michael.christie@oracle.com>
To:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, brauner@kernel.org,
        ebiederm@xmission.com, torvalds@linux-foundation.org,
        konrad.wilk@oracle.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH 06/11] fork: add kernel_clone_args flag to not dup/clone files
Date:   Fri, 10 Mar 2023 16:03:27 -0600
Message-Id: <20230310220332.5309-7-michael.christie@oracle.com>
In-Reply-To: <20230310220332.5309-1-michael.christie@oracle.com>
References: <20230310220332.5309-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c2F6t/vI+yRblQSgXvJUIq0VY5+OWF4XVmyf8wt0Rv7p4KxylzlKuWkPRcvl?=
 =?us-ascii?Q?XQcpSqsZpRLNTWGcYJj13wsrG5FclgOKSV4P8Q+MNX3Ri9bc3IhC1kccO7pH?=
 =?us-ascii?Q?bIqEIfnMCf8Ktvoqkye+3bTSxqJnjdcmbN0gfA8M9dqn9rAHusHxI29uI7VC?=
 =?us-ascii?Q?KbC5Dk/Y/Isot1RLbWzpacpSYBtPknLq+eDXdYWwvCSDithGqIPTwcrgCdb4?=
 =?us-ascii?Q?/sZ9vyNOjcXc18DEj98puoRrEpeiFXZEXOm9VQSppl3DJfIQHHArYYSEB2Po?=
 =?us-ascii?Q?FQBcJhLpII+f7BT41Ld5o1wJgeHuD+xg1KZMwqZLQvlbEzixIow26D2NkgpR?=
 =?us-ascii?Q?S3MnIrzAhdTMJIDOIQ5sb1a557OiQ3dLF/RZu+lXFwW2AjuofeT4xq6KGDWW?=
 =?us-ascii?Q?xroms0dBkVEke9lBt+Kc3lgKJS9JvHZVQc+IqGTRU/CmkkpO9lOq12nKp41f?=
 =?us-ascii?Q?ZQ7h0tpm8HyyV041QW0my/F6IXzlrNdLHy3TjIIUqKE+a/Xv9oAPYa4Xhue3?=
 =?us-ascii?Q?1hsveLa0H9/sMOH+JNB53PWjk9tDvbu+fmHou1Afv2Px2zNFMLumwwYAmRGi?=
 =?us-ascii?Q?0zgZgKZgJHaTPL1K+lbGJywTVZzqoO29XjIhV1NFmdoHjcU91BpPyVl4y8k7?=
 =?us-ascii?Q?ZlmNjIy1XepmxKt3m71NXvXLxp+YaMQkLJLQYInoAZUJnza4/jFrcJXd7FSc?=
 =?us-ascii?Q?ec4IpWyq/316gXILtx3i0OLirqRXX6s5njUSvHszPR8RIX+MnP0MdPjwycZh?=
 =?us-ascii?Q?NoF/TCb4RUe7/OTDNbjVlH81Fycr/CcDDJbPhc+3UwnqYFujs/v5geMs2TNk?=
 =?us-ascii?Q?HfaFLUrB/q7AuEAJEs3UK+8idjHG7rB4v+kcdG2ZEiraINFYCxEgAzmLcafZ?=
 =?us-ascii?Q?8+hF2xjNeAuAJ+I418IEdma1OGUuMUVTg1ZfhmdH+xuq1b27QBnR3g/40k5P?=
 =?us-ascii?Q?Fwl/ZHX1yklBrAjzdZ4uw9r9uE32Uy8hLEyYDlPjvRsVoHZKqvwwQcjZ+Fzl?=
 =?us-ascii?Q?Zmh+d/NzSl/mPEnSmKMpEvJ4ln4WSTXimBCYazcNu3Btiej+mTdbO5oU1gcK?=
 =?us-ascii?Q?8doM+gwN3b4zrziCYTX8f4DeIG2MSGfv46nPNs/X+BVkGBfQR9wtoDtPblQ9?=
 =?us-ascii?Q?7f1iQlg8GtzxhDdFVLcq5NpwQRxYFRkC08lYv14l+R56H4fOxNbutjWXz8pM?=
 =?us-ascii?Q?guzE4Ym2KhBhebKYTiACvrnO7PLsQ7LrXPz3TtWZRdVZ/EIadvQd2koZ91vE?=
 =?us-ascii?Q?9Va24C1dp+aFpPsI/C+S3q/8YcnL0Fur+X0G0pUlJsrrYXN5s8+9FYNeZ26o?=
 =?us-ascii?Q?Aw+DcemwbJENiyf+8D0Jbu4Rv2Itsfb33UpbIUbfu9ntaUHkKoLOgI1CwBvF?=
 =?us-ascii?Q?T7omJcNPlCdGPmAKn16FOm3u0gEdPi/fIQuCRd/E0HycA8UZg4C9Hxos3SsJ?=
 =?us-ascii?Q?qLqAlBtZcTICcZEk8B4gvG3eZaYGhL+Nfwjrgxi1IWS0Ub9k7xr2Nv+qqzll?=
 =?us-ascii?Q?kbbkHVlNRpK9qc3wo2277fQAAbj+nZuuuLYuOJwac3dYxEKECKGfVjOMFQO0?=
 =?us-ascii?Q?WwQTH6+a1LVTbozSCamDMOnodMqvq+Vx53B/HDM8fSgR4khY4UnxvcvsanaO?=
 =?us-ascii?Q?Ww=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?mbbkuhL8BB+EcF/8T2hbMOmymLjKwhMZI1XzfQffLTgXAbUxC9vLsPeLJrlB?=
 =?us-ascii?Q?Bfgf/Kj7RUpuYwH/sdBydNHK7Eaqh7kW7dBk0oVLn3Qm3xD4mFGlUcyIWSpf?=
 =?us-ascii?Q?+LBq2HAEI6CO/Qa+y45sxA85+sbYMCxa78Js9EoMxZL+s78iD4DOXMp2+PcS?=
 =?us-ascii?Q?m2SHYreWjlKzzl038CY3oSoNZenyuZQhP9x7L9dj4XWP2lYJa39MBCaC6mL3?=
 =?us-ascii?Q?8p2Qs4M8kbcUZkWlmyluUlzsaEolb83CFO6cq1ImQ0DzeKKuFU7qYFZ5AGs7?=
 =?us-ascii?Q?x++nzvni8srLU7KltgGtlxuHpRs6lFAm75BRgC4ugBJsOd4yt9Nso1zpnujo?=
 =?us-ascii?Q?jqbsO9qWDgYzZhG9tcn7dE/MVVHWOWUPUvHtokEfvL9KBZXrnJGWTR+p2gCr?=
 =?us-ascii?Q?j5xuIGd+RzDdsX8nlqIQZRv/evmUDUhS4T4BktrVYUJ1QmZhihlx572bXJjg?=
 =?us-ascii?Q?avFo5h41xvFGx7DiNxmXw9+YiWgicxbkn38Bi8Pd/lA0kzPxdEIwXVTafA9+?=
 =?us-ascii?Q?ZEq+VjqAVqJjJyfWPLtz0nAegx1ESMm5S8ut+WKTObOafH4qWJ7NrHDKM/z+?=
 =?us-ascii?Q?/wauF5+jNGhdU2MzwVsNerfAG/6/MFIDzaJuF579cfURABYfH3ZGtmz1jbCr?=
 =?us-ascii?Q?38+ZRxoxgfr8CUWlctNSrQ0nFKsejt102cYSmNXjlH/qksjUMUyF9GcrmAZ7?=
 =?us-ascii?Q?KfFK7hJ+fcIiI3sXQx3ZEN2ajGgHiYlKZNsSBxyhJiFM7ZnW8DeJt3BUJnFB?=
 =?us-ascii?Q?3h6zmk7DKqRKcRLbr0Dtcs42ZWwMfVIZCtWA2OQ+BBZ2/BjP85l3nItJF4r3?=
 =?us-ascii?Q?19cKj/chXwGU0IvLBp/Z34BvC8VUfEGlPj3U2fZytnSwHOf8sOAVFxIpAFC9?=
 =?us-ascii?Q?TnoW4eBERUMo0vmXMUyvJ/Yk/K0nPyGH7HZILKH/J0H+s/9Vothrpv/POVje?=
 =?us-ascii?Q?mBiNvebX7Z2eyPtcenVtK9SgQYTeNFK9tY3rJv/zYXp1DGDjChu+hcvATntR?=
 =?us-ascii?Q?lQ1PjtwSQefHeqx1iAoszKDuN6zdk7nOEYSpD3wetKBVY4I=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c56315b-14ff-482c-5e93-08db21b35123
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 22:03:44.8598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zMxCX90nlpuzAk9OIqreSOOZp+SXuZbXeN74YbbwnApWkm0qOfnAh6tBubwY+xZkf/1Uw6naT7fwjp4EuCkAUf+Q4V6bgTX7UrqrZibNn+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6514
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-10_10,2023-03-10_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2303100176
X-Proofpoint-GUID: yunMcCpsoCdzbFHPRgbhRnZbPQ69Re0O
X-Proofpoint-ORIG-GUID: yunMcCpsoCdzbFHPRgbhRnZbPQ69Re0O
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it creates a thread using a helper based on
copy_process we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <brauner@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 10 ++++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 2950e83d5382..4f816048794f 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -28,6 +28,7 @@ struct kernel_clone_args {
 	u32 kthread:1;
 	u32 io_thread:1;
 	u32 user_worker:1;
+	u32 no_files:1;
 	unsigned long stack;
 	unsigned long stack_size;
 	unsigned long tls;
diff --git a/kernel/fork.c b/kernel/fork.c
index 0dec38276363..258163ea5cd2 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1624,7 +1624,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1636,6 +1637,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2256,7 +2262,7 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p, args->no_files);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1