Date: Sat, 15 Sep 2007 18:51:53 +0000
From: Paul Rolland (=?UTF-8?Q?=E3=83=9D=E3=83=BC=E3=83=AB=E3=83=BB?=
	=?UTF-8?Q?=E3=83=AD=E3=83=A9=E3=83=B3?=) <rol@witbe.net>
To: eric.valette@free.fr
Cc: Rob Hussey <robjhussey@gmail.com>, flamingice@sourmilk.net,
       andreamrl@tiscali.it, linux-kernel@vger.kernel.org, rol@witbe.net,
       Johannes Berg <johannes@sipsolutions.net>
Subject: Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as
 a module. Works as a module.
Message-ID: <20070915185153.08490a9b@tux.DEF.witbe.net>
In-Reply-To: <46EC24B6.2030709@free.fr>
References: <46EBE70C.2040201@free.fr>
	<46EBEBD2.7060502@free.fr>
	<6b8cef970709150928h25a7093md5f86d2bdcf677cc@mail.gmail.com>
	<46EC24B6.2030709@free.fr>
Organization: Witbe.net
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1198
Lines: 33

Hi Eric,

On Sat, 15 Sep 2007 20:30:14 +0200
Eric Valette <eric.valette@free.fr> wrote:

> Rob Hussey wrote:
> > On 9/15/07, Eric Valette <eric.valette@free.fr> wrote:
> >> Eric Valette wrote:
> >>
> 
> Thanks for your help: it does indeed fix the problem.
Nice it works for you too !
 
> Now I have two side questions:
> 	- the code is no more symetric "subsys_initcall" -> "module_exit".
> Do not know if it is "normal" but I love symmetry in code :-). Did not test
> it still works as a module...
Symmetry is not broken, as we have :
#define subsys_initcall(fn)             module_init(fn)
in include/linux/init.h where compiling as a module, and when not compiling
as a module, I doubt the exit function is called unless you are shuting
down your machine...

> 	- Who takes the responsability to push a patch to Linus? I guess it
> is urgent unless he plans a rc7
Good point ! I expect the patches to be already in some queue waiting to be
pulled !

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/