Message-ID: <7dcfc21e-9a17-65b1-6206-374cadb79973@intel.com>
Date:   Fri, 10 Mar 2023 14:25:30 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.2
Subject: Re: [PATCH v8 0/6] Some improvements of resctrl selftest
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230215083230.3155897-1-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230215083230.3155897-1-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmtPeCtFZkNzK054YTRQQjZ0cUc0eUh6V1ptWkd5S1RKRCtlem85c0lYTW9Y?=
 =?utf-8?B?MkV4TzVMRXJMczVUYVVyOU1oSGRTUjN1ZWp3YVdDdnhIN2loZFUvWXp6N0Nl?=
 =?utf-8?B?ZTVtKzNxWnBLNDVNVEI2WkxEZTJCNVEyQ09wU3ZJQWoyS044WENUZGtNMkQ3?=
 =?utf-8?B?ekpra2N4Z09raldFOWxOa3RGdnA2Qm1adFpUL3djejFVMnFTOFdDVTNuZmhO?=
 =?utf-8?B?aFpzb3RtbW93YXdKUTY1QWc3TUZFQjZ6RmhDV0lEVXRZTFZHL0ZqNUoyb1Vm?=
 =?utf-8?B?REd0Ny9qQk1rbnNBRHRYRjE3ZnRxNGVMeDRWYTU3UTUxbEhaYm01aEgvZzBh?=
 =?utf-8?B?V1FmWFc4ZVBEZjlTVFgyNWVNQ0VHNXNhUVh2WVZoT2JkRTZGZ1hSN1pZMFF5?=
 =?utf-8?B?ME42bDJHWTlKZzIvREJ4czA5L0JzeXEzYUdySUR5Yk5ITjcweGpWZUx0dnRB?=
 =?utf-8?B?NVRWa3FEb2d3b0ZPd2hGRG41RElyblVWR3Rra3hoR2srN2ZFbDU1ZGR4QmxS?=
 =?utf-8?B?QkdqUmtTeVFIMWRWcHZpTEVrVUNrSHNDRkdTdmQyTU55dk9VYytBMnRkQWNa?=
 =?utf-8?B?MytmNUFXV3VmK3lMcTRwZVMwMGhCSVFIQmpGVVM2YzVKUUlFWkQvaWpmNHI0?=
 =?utf-8?B?dG1uV1hrSCtzUEhod3BhS2hFY3N0T2hQME5xYW51Wk5QRmI1eGN3dWhFNWJh?=
 =?utf-8?B?YmhtbW1JVnhQeEFnOU90ZnVwYnF1MFFjQWdZRUJpdlcvY1YwUHFiS3JHQjRU?=
 =?utf-8?B?eStKUDQ2ZEJaTU0zT2F3Mi8vMG5tTkJEbkIweGpXd29SY1JZU0lVUXltUmJ1?=
 =?utf-8?B?Z0dKVmF3VXEyZ1FueVJ3R1I4Nk8yQ1R3MlBtNjFFR3plblViRStuc2ZLVnhq?=
 =?utf-8?B?V3EvVlYzQVpMZ25QVFE1QzFjQUx2N243YWxiUHI5L2ZURGI4K0s5cTVEaVZX?=
 =?utf-8?B?dXUvY3JjdG9xK3ZlaXhKUFVjU3krblRBSVNQQWlqa1JSTlY2bXd3NExNVURG?=
 =?utf-8?B?c2VBd0RVT3EvMjlWVXUwR2NZOWZGNUVEYzZ5dGYya2d6bGwrQ0xwaXhUeG1X?=
 =?utf-8?B?bFgrcUlTeVFCdUo3eXZoVGVoUysrNWIvbTZOT2E0eVZESXZEM2NWa0xuNmRu?=
 =?utf-8?B?NkxvQkd0RWo4bys1eXNWYzcyZXk0WGtOOHI2dmlNQTJkTkJXZlJ0MC9rdnYz?=
 =?utf-8?B?V1RqaXI2SUtMVldQMnpYemtzcDNMeG8wQkVxd2RCejQwYXhrNTY5TVhrTDRL?=
 =?utf-8?B?RUNvRUNhcGNRN0dNQ0xtZE8wSENDSFM2VUl5UExVTWRvN2xlTTc3SjhFY3Av?=
 =?utf-8?B?SjJuMHh0YmN5bmVhbmg5a250S2l1MFdWblMwTW8yMlZZdmdNWVhET3AzSm5J?=
 =?utf-8?B?YVBvMU1tVE1qOTRVZ21XYTBicXBwN2o4SXArQkh4eWx4U3VLaFljMDlGeUxi?=
 =?utf-8?B?eGtmYVVrZXVyQUJyd1BsdnlURGZOekNrano3WnpwZzdTRWJKLzlCWkIvcm80?=
 =?utf-8?B?bnYxNmVOcDZjQWJpVUNscFk5S2s1MzVtVTRLdzY3cDl3OTVTQVJJWmhIRVNL?=
 =?utf-8?B?bkFCeVpzS3RBM3pzNVFzWlA2WThRN1lGNFVkMjlOU1cwY25PdWlzMHlUSk52?=
 =?utf-8?B?a1NWUUdsSkMrT0doRkQzYkhPai9WNmE3MUNGejhQSTRUU0dMYjJjc2NMTDJ5?=
 =?utf-8?B?VXJOU1lnc0dlb01FV2trOXIzUHJjVFJoQTRwQ2M2K3ZSdURndnBLeWNxYXc2?=
 =?utf-8?B?a2o2M0JHNWk1MHRwMFg2dldFNHJOb2U0dVRYNm5WN1ZwRnlpQnRUOVpqNXlT?=
 =?utf-8?B?ZFZrbk1kT2p3RFFmNU5QbHRpOElRZnVLQWIvMUxqNXFhSW5SRGFyblg5U0hD?=
 =?utf-8?B?cU53QUlveHBhMEljMTlsR2c0dzZXOVF2SFNHMW1CNmRzd08zWFB5Tk00Sy90?=
 =?utf-8?B?WloxamhReEVKN09WcU9aTzgzS0wzSE5Ga2NjbGkxUUdtOExFcWdaVzdqbGh5?=
 =?utf-8?B?SGtyTzBFMGkxRjNUMC9WZHYrTlJMSDRaeHZ4enhINGxGSFdnbXVGM05hcXdJ?=
 =?utf-8?B?aHNheHh3ZUpkeC8zcFZJcWdya1pqbkpqbnVCV3FHaWFJTk9CanJVUFc1SmdK?=
 =?utf-8?B?b1pyNlBvcDYzb0tvVGpINkJnUXdaMkUzS3lXVjd2RDh1a2FIeWcyMEFvcTgz?=
 =?utf-8?B?b3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 980d09be-9a20-4c3b-6e85-08db21b65d12
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1867.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 22:25:33.5749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y1lW6L3F04NmrFnHLxe7LEM3YHMDzpr1F46BZINscjDpholKV2q8yWjkVsIKESt1gzCQDjjd9Fy4SgalS/XAhzWE/sIr9uNHfbFkTLx30yc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5779
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shuah,

Could you please consider taking this series in via the 
linux-kselftest tree?

Thank you very much

Reinette

On 2/15/2023 12:32 AM, Shaopeng Tan wrote:
> Hello,
> 
> The aim of this patch series is to improve the resctrl selftest.
> Without these fixes, some unnecessary processing will be executed
> and test results will be confusing. 
> There is no behavior change in test themselves.
> 
> [patch 1] Make write_schemata() run to set up shemata with 100% allocation
> 	  on first run in MBM test.
> [patch 2] The MBA test result message is always output as "ok",
> 	  make output message to be "not ok" if MBA check result is failed.
> [patch 3] When a child process is created by fork(), the buffer of the 
> 	  parent process is also copied. Flush the buffer before
> 	  executing fork().
> [patch 4] An error occurs whether in parents process or child process,
> 	  the parents process always kills child process and runs
> 	  umount_resctrlfs(), and the child process always waits to be
> 	  killed by the parent process.
> [patch 5] If a signal received, to cleanup properly before exiting the
> 	  parent process, commonize the signal handler registered for 
> 	  CMT/MBM/MBA tests and reuse it in CAT, also unregister the 
> 	  signal handler at the end of each test.
> [patch 6] Before exiting each test CMT/CAT/MBM/MBA, clear test result 
> 	  files function cat/cmt/mbm/mba_test_cleanup() are called
> 	  twice. Delete once.
> 
> This patch series is based on Linux v6.2-rc7.
> 
> Difference from v7:
> [patch 4] 
>   - Fix commitlog.
> [patch 5]
>   - Fix commitlog.
> 
> Pervious versions of this series:
> [v1] https://lore.kernel.org/lkml/20220914015147.3071025-1-tan.shaopeng@jp.fujitsu.com/
> [v2] https://lore.kernel.org/lkml/20221005013933.1486054-1-tan.shaopeng@jp.fujitsu.com/
> [v3] https://lore.kernel.org/lkml/20221101094341.3383073-1-tan.shaopeng@jp.fujitsu.com/
> [v4] https://lore.kernel.org/lkml/20221117010541.1014481-1-tan.shaopeng@jp.fujitsu.com/
> [v5] https://lore.kernel.org/lkml/20230111075802.3556803-1-tan.shaopeng@jp.fujitsu.com/
> [v6] https://lore.kernel.org/lkml/20230131054655.396270-1-tan.shaopeng@jp.fujitsu.com/
> [v7] https://lore.kernel.org/lkml/20230213062428.1721572-1-tan.shaopeng@jp.fujitsu.com/
> 
> Shaopeng Tan (6):
>   selftests/resctrl: Fix set up schemata with 100% allocation on first
>     run in MBM test
>   selftests/resctrl: Return MBA check result and make it to output
>     message
>   selftests/resctrl: Flush stdout file buffer before executing fork()
>   selftests/resctrl: Cleanup properly when an error occurs in CAT test
>   selftests/resctrl: Commonize the signal handler register/unregister
>     for all tests
>   selftests/resctrl: Remove duplicate codes that clear each test result
>     file
> 
>  tools/testing/selftests/resctrl/cat_test.c    | 29 ++++----
>  tools/testing/selftests/resctrl/cmt_test.c    |  7 +-
>  tools/testing/selftests/resctrl/fill_buf.c    | 14 ----
>  tools/testing/selftests/resctrl/mba_test.c    | 23 +++----
>  tools/testing/selftests/resctrl/mbm_test.c    | 20 +++---
>  tools/testing/selftests/resctrl/resctrl.h     |  2 +
>  .../testing/selftests/resctrl/resctrl_tests.c |  4 --
>  tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++++++-----
>  tools/testing/selftests/resctrl/resctrlfs.c   |  5 +-
>  9 files changed, 96 insertions(+), 75 deletions(-)
>