Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EBEC6FD1E for ; Fri, 10 Mar 2023 22:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232113AbjCJWbJ (ORCPT ); Fri, 10 Mar 2023 17:31:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232089AbjCJWar (ORCPT ); Fri, 10 Mar 2023 17:30:47 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A2B13F57B for ; Fri, 10 Mar 2023 14:29:40 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id j11so26475290edq.4 for ; Fri, 10 Mar 2023 14:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678487379; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zZBiSBh/uMHLxNGMJD5/x7iKpfjagyjpgEMbyA0c4IY=; b=kI8tbYpRepNoWUOIKSEz3YzOMlaj+FiVTekSncMStWDI5O7kelt7UpFXprP2HySvV1 /8uVzvFEtlcvTuPOkrWbbOL3zZrTmcV7uMKQO0j1YcNm3UYdT4vBQhvY+YUpuA7pqmuv WxeNVsD7qw9YZZ68yAAPsoiYQTCkD+//U41hA5Ij7xx2Yf8CK35RtWTwy4WLTPqr89ON 9eygPHgv6mxlMhxleYm1MlBp71KBVomYKgGcgONPmUJsCd2rvy4uu2jeESLevIctmwka nMAPxEb1MykjP7rfo8HywrvX0tihJGGiMW1X5jvUnetfWU9NVQ2Qc+tt9+J/2mYGcth3 HR0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678487379; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zZBiSBh/uMHLxNGMJD5/x7iKpfjagyjpgEMbyA0c4IY=; b=oubfioskCU7eU3NCjM6wUCa/WtNTSdceJiuZHtx7KTWb/uxqV/4GWLNjQz8vyDDc5H gjho4M0t4f/p+1viPI9MzeS/cr0Szp44cW2pPdJIIvxT3sDrR3lkT5cRfk+UQygAVGhk YeNydfpnw6t5sXaefoztjV/4Zgf7jzTtJJsfZnF7KnXawI+cAVzK3cDjVrMr+tVqNzvL o0oIrc74445s+zKmlIVBRZaX1wNoZP+NseEL0sonBQ7wVZAPI5IZUbjWriuLvKNURBMd 28UrHpV2OxELYOIdxAzQ7WpGe21zFpKMKF48mPHMt5ngRgvQYrvNmAIZ9ga0LRzOq1g+ frjw== X-Gm-Message-State: AO0yUKVBIHfNvePDM7/3Tkkxmq3A48FUqcBVPs8lJrnbHnpSEUVgQuJM SXp6a6gJhvyjf+nZfBnb4Ab+Ew== X-Google-Smtp-Source: AK7set+U/X5h1L8f+O6dk2UpzKGGJkAH3/87LaLO1bo9+b2A4dcWda14m+u/RspMEgdY+VIIzKQCRQ== X-Received: by 2002:a17:907:98d2:b0:8af:54d0:181d with SMTP id kd18-20020a17090798d200b008af54d0181dmr23195756ejc.35.1678487378977; Fri, 10 Mar 2023 14:29:38 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:34:52e3:a77e:cac5]) by smtp.gmail.com with ESMTPSA id d5-20020a170906370500b008e17dc10decsm371201ejc.52.2023.03.10.14.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 14:29:38 -0800 (PST) From: Krzysztof Kozlowski To: Heikki Krogerus , Greg Kroah-Hartman , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] usb: typec: hd3ss3220: Drop of_match_ptr for ID table Date: Fri, 10 Mar 2023 23:29:36 +0100 Message-Id: <20230310222937.315773-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). drivers/usb/typec/hd3ss3220.c:284:34: error: ‘dev_ids’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/usb/typec/hd3ss3220.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c index 746ef3a75b76..8bbeb9b1e439 100644 --- a/drivers/usb/typec/hd3ss3220.c +++ b/drivers/usb/typec/hd3ss3220.c @@ -290,7 +290,7 @@ MODULE_DEVICE_TABLE(of, dev_ids); static struct i2c_driver hd3ss3220_driver = { .driver = { .name = "hd3ss3220", - .of_match_table = of_match_ptr(dev_ids), + .of_match_table = dev_ids, }, .probe_new = hd3ss3220_probe, .remove = hd3ss3220_remove, -- 2.34.1