Message-ID: <46EC2BBB.1030506@free.fr>
Date: Sat, 15 Sep 2007 21:00:11 +0200
From: Eric Valette <eric.valette@free.fr>
Reply-To: eric.valette@free.fr
Organization: HOME
User-Agent: Mozilla-Thunderbird 2.0.0.4 (X11/20070828)
MIME-Version: 1.0
To: =?UTF-8?B?IlBhdWwgUm9sbGFuZCAo44Od44O844Or44O744Ot44Op44OzKSI=?= 
	<rol@witbe.net>
Cc: Rob Hussey <robjhussey@gmail.com>, flamingice@sourmilk.net,
       andreamrl@tiscali.it, linux-kernel@vger.kernel.org,
       Johannes Berg <johannes@sipsolutions.net>
Subject: Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as
 a module. Works as a module.
References: <46EBE70C.2040201@free.fr>	<46EBEBD2.7060502@free.fr>	<6b8cef970709150928h25a7093md5f86d2bdcf677cc@mail.gmail.com>	<46EC24B6.2030709@free.fr> <20070915185153.08490a9b@tux.DEF.witbe.net>
In-Reply-To: <20070915185153.08490a9b@tux.DEF.witbe.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 973
Lines: 30

Paul Rolland (ポール・ロラン) wrote:
> Hi Eric,

>> Now I have two side questions:
>> 	- the code is no more symetric "subsys_initcall" -> "module_exit".
>> Do not know if it is "normal" but I love symmetry in code :-). Did not test
>> it still works as a module...
> Symmetry is not broken, as we have :
> #define subsys_initcall(fn)             module_init(fn)
> in include/linux/init.h where compiling as a module, and when not compiling
> as a module, I doubt the exit function is called unless you are shuting
> down your machine...

I came to this conclusion too. But I would have preferred to have
#define subsys_exit(fn)			modules_exit(fn)

in the case of a module and nop in the non module case...


-- eric


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/