MIME-Version: 1.0
References: <20220928122539.15116-1-pali@kernel.org> <CACRpkda-WcnRdwYNi0oeZsvX9xO+ECBF15rd41+Pr+MWmrZuBg@mail.gmail.com>
 <ZAs3SgNsYb31x4UU@lpieralisi>
In-Reply-To: <ZAs3SgNsYb31x4UU@lpieralisi>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 10 Mar 2023 23:38:50 +0100
Message-ID: <CACRpkdZN=Rid894wruY14b+yFt3su8ejJbKbEH57ynoDxce8qQ@mail.gmail.com>
Subject: Re: [PATCH] PCI: ixp4xx: Use PCI_CONF1_ADDRESS() macro
To:     Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 10, 2023 at 2:57=E2=80=AFPM Lorenzo Pieralisi <lpieralisi@kerne=
l.org> wrote:
> On Tue, Oct 04, 2022 at 09:56:18AM +0200, Linus Walleij wrote:
> > On Wed, Sep 28, 2022 at 2:25 PM Pali Roh=C3=A1r <pali@kernel.org> wrote=
:
> >
> > > Simplify pci-ixp4xx.c driver code and use new PCI_CONF1_ADDRESS() mac=
ro for
> > > accessing PCI config space.
> > >
> > > Signed-off-by: Pali Roh=C3=A1r <pali@kernel.org>
> >
> > I have no way to evaluate this change in my head, once the kernel test =
robot is
> > happy I can test the patch on IXP4xx.
>
> If you can manage to test it I can go ahead and merge it.

I managed to test it with a oneliner to add the right include on top
of v6.3-rc1.

Yours,
Linus Walleij