Message-ID: <a5962d12-ccd2-79ea-27bc-674e0b3065f4@linux.intel.com>
Date:   Fri, 10 Mar 2023 16:46:13 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH v1] ASoC: Intel: sof_rt5682: Enable Bluetooth offload on
 adl_rt1019_rt5682
Content-Language: en-US
To:     Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Cc:     linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Brent Lu <brent.lu@intel.com>,
        Yong Zhi <yong.zhi@intel.com>, dharageswari.r@intel.com,
        Vamshi Krishna <vamshi.krishna.gopal@intel.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        alsa-devel@alsa-project.org, Mac Chiang <mac.chiang@intel.com>
References: <20230310184201.1302232-1-ajye_huang@compal.corp-partner.google.com>
 <0456bd4e-cfee-b863-e02d-98084b5da0f6@linux.intel.com>
 <CALprXBamM-M-YdyfX9dQHp_AQAovcqzL5H4rMPsZPXS426+VgA@mail.gmail.com>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
In-Reply-To: <CALprXBamM-M-YdyfX9dQHp_AQAovcqzL5H4rMPsZPXS426+VgA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/10/23 14:01, Ajye Huang wrote:
> On Sat, Mar 11, 2023 at 2:48 AM Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>>
>> This sounds good, but if the intent is to have BT offload enabled across
>> all ADL skews there are still misses, e.g.
>>
>> .name = "adl_mx98357_rt5682",
>>
>> Can we please try to add this BT offload in a more consistent manner, or
>> add a comment when this is officially not planned/supported?
> 
> Hi Pierre,
> 
> The "sof-adl-rt1019-rt5682.tplg" for this "adl_rt1019_rt5682" sound
> card also need to enable bt_offload, this one I will submit to SOF
> later this weekend.
> ex, topology: sof-adl-rt1019-rt5682: add bluetooth offload uses SSP2
> link -- https://github.com/ajye-huang/sof/commit/09dcbc3cc1617df652944299c63082f1936dea6e
> 
> To be more clear, I think we can add a comment in the commit message
> for mention " The related "sof-adl-rt1019-rt5682.tplg" enabled the
> bt_offload feature", is it ok?

It's best if you provide a series that enables BT offload across the
board for ADL, if that's the intended goal.