Date:   Fri, 10 Mar 2023 17:29:07 -0600
From:   Jeff LaBundy <jeff@labundy.com>
To:     Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Munehisa Kamata <kamatam@amazon.com>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH 3/4] pwm: iqs620a: Explicitly set .polarity in
 .get_state()
Message-ID: <ZAu9Q9gfkJwM3szn@nixie71>
References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de>
 <20230228135508.1798428-4-u.kleine-koenig@pengutronix.de>
 <20230310184815.x5v2ysyeyshnapm5@pengutronix.de>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230310184815.x5v2ysyeyshnapm5@pengutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?o42F49OzT7VtMVRW6dELaHEQHzlVWwjLVqBTodvLrhBnz9fnhw13X6tVjH?=
 =?iso-8859-1?Q?DYZdXLB6nGDKhd4EfcpTBdJ9mxFllFFYOBcdB3vGoSe/jp87DLXmcUJGm6?=
 =?iso-8859-1?Q?qKcRiPCV+4lFFEk8VkEsu+Ro+/K3HAJcq+1MsrSHm/y9IttXbql9GbZfrH?=
 =?iso-8859-1?Q?dD9/A6U1qjDrXfrq0mkA7QwNlwYuG4yNlSzUwE3h0oZiQqMxRLzKTQ6+Nv?=
 =?iso-8859-1?Q?9AausVo4U4WNrasWPiUG5dS98XVCGkVuOAeoqkQjBD6z+m9BPPh2vbsA98?=
 =?iso-8859-1?Q?WJLwuL6+5aGb3+QLnAFNlRupIgTSWT6pg4Ed+5CO+IGhwwywaWPMZ4IN02?=
 =?iso-8859-1?Q?/5nTe/ZZqWa1Mqn9hfMKV5xDgiZGXB/M6Yb8N/1x1HkbBRzJ6jbHChm4yu?=
 =?iso-8859-1?Q?JFdFCbO91fUEU7BECm43Q1Q7XrdNkg7lOZ/HI6LNIvsLHd8oG6NnXJ7nSg?=
 =?iso-8859-1?Q?OTGxxcd/SZEQUn2sU2XEVksHi8wSPMWZrOEaX1HzxiJqpz0rgIv0VHGQc8?=
 =?iso-8859-1?Q?I0uC6RS+x5xhvdbCiP3ijLfCDhPch2fsnHh57sBhvYx2coVwlZTOXC/pYg?=
 =?iso-8859-1?Q?kV9y8T7SRBmmwtR1tRn0bASfZaopyuUTQ1Lr4MEoKWvkyQNEP04UmLDU/c?=
 =?iso-8859-1?Q?11LjrrzVhOkqsuT+OWK20FdZUFWVsaV3eWA82RL+7wiGedX9rkDxOq8oCj?=
 =?iso-8859-1?Q?MsRPsjuBQanvJzoBwEHgaSEpLrmL9bQmid/l2mW47E4MQnJ+rVHaPCcoV3?=
 =?iso-8859-1?Q?0HOpA90wf71Y1ZFhHJE7JCIzugbemr2QbEgur/x5B+DL3hWiQN3LVAy20X?=
 =?iso-8859-1?Q?uiGaMDUlBwaKDnYAUMunYxFHYeh4WiOTbaNYytetjLjl8H/gcaXHBeCrFL?=
 =?iso-8859-1?Q?LKta+2uE5Ch5zk9WGcaVl4c+h2ya9R4+gfm7KECQxgCzHlPtBpwIXuPY95?=
 =?iso-8859-1?Q?D4nIzahZahm1LgqPfeNuQ+m1P7aN84CubbW6fqlFVgnT7mDMihzwozDaPC?=
 =?iso-8859-1?Q?i/fo24sXbI+Zir1hc4FLcS4boezHfZsqnQOMxbe10lvRQ15ARHUvfqbtaA?=
 =?iso-8859-1?Q?/PweCBWoLNuG4pjR86QSSwn8fEMifHM1SmbgX5cq7V9kOKDseapdOPKgZj?=
 =?iso-8859-1?Q?iAkbw8qe0emQ9Jy1GxxY7io7AqbGUbJYaCY1f8ib/7xqyoq0fMOJPpv1vY?=
 =?iso-8859-1?Q?iITpq6LzWQtovt9vXuKOltkGs6rZjVm4skVHQ67nURQSXMjkq7jpfgD40Q?=
 =?iso-8859-1?Q?TkasXuBsNpI2rjTelY7DKgNOr6g1c8vDhrEdxBEMLr273wsXuYSr/8OrSz?=
 =?iso-8859-1?Q?cw7ScI3efudR2wrazS4kvHjPhCDEFCLSvhs7PaMooUGAlkjsj8sLJI0zxc?=
 =?iso-8859-1?Q?CGHtJ2t9glq6x0Cfizp/PrhFopjKOVujbx/9QcyUdl0BfGh6fHBxeLA+q7?=
 =?iso-8859-1?Q?YrA1U/DnJr3lq872jGTsEMv6q9IR3d1xTunkPga2LnssmARq802Wxn6C2M?=
 =?iso-8859-1?Q?9HmVkDlpRMMgbqzt1syk7GEc8SlQoSb5vNUaKBBb51rClAXZA1cYttLPSo?=
 =?iso-8859-1?Q?Y4/UZzGkBuJu1PS9YoZEuuklHNklmbOoSmrD6VmgpS18mxS5ko8YH+Lal0?=
 =?iso-8859-1?Q?DGbxg6LmhPSseIfPTQMv9KnyKYVap1hEb7?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13a4dc3d-a4cb-4ad2-2c8d-08db21bf4043
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 23:29:10.5390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F/KqHbSmTxhojrGk7EHout3TiyKz0suAP4NR6Xp+wsyuXbdu8LJuF4j2RAnjRbJsvWqR/EjlVpFKLhAFHHERdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR08MB7458
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 07:48:15PM +0100, Uwe Kleine-K?nig wrote:
> [To += Jeff LaBundy]
> 
> On Tue, Feb 28, 2023 at 02:55:07PM +0100, Uwe Kleine-K?nig wrote:
> > The driver only supports normal polarity. Complete the implementation of
> > .get_state() by setting .polarity accordingly.
> > 
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> 
> I think we should apply this patch as a fix to prevent similar failures
> as reported for the meson driver. To justify that:
> 
> Fixes: 6f0841a8197b ("pwm: Add support for Azoteq IQS620A PWM generator")

Reviewed-by: Jeff LaBundy <jeff@labundy.com>

> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-K?nig            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |