Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58690C6FD1E for ; Fri, 10 Mar 2023 23:34:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231755AbjCJXev (ORCPT ); Fri, 10 Mar 2023 18:34:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231589AbjCJXeq (ORCPT ); Fri, 10 Mar 2023 18:34:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C90A9115B6F; Fri, 10 Mar 2023 15:34:40 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6D21FB82433; Fri, 10 Mar 2023 23:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF026C433D2; Fri, 10 Mar 2023 23:34:35 +0000 (UTC) Date: Fri, 10 Mar 2023 18:34:34 -0500 From: Steven Rostedt To: zwisler@kernel.org Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Ross Zwisler , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Hao Luo , Jason Gunthorpe , Jiri Olsa , John Fastabend , KP Singh , Leon Romanovsky , Martin KaFai Lau , Mykola Lysenko , Shuah Khan , Song Liu , Stanislav Fomichev , Yonghong Song , linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org, "Michael S . Tsirkin" Subject: Re: [PATCH bpf-next v3 1/2] bpf: use canonical ftrace path Message-ID: <20230310183434.64ade329@gandalf.local.home> In-Reply-To: <20230310175209.2130880-1-zwisler@kernel.org> References: <20230310175209.2130880-1-zwisler@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Mar 2023 10:52:08 -0700 zwisler@kernel.org wrote: > From: Ross Zwisler > > The canonical location for the tracefs filesystem is at /sys/kernel/tracing. > > But, from Documentation/trace/ftrace.rst: > > Before 4.1, all ftrace tracing control files were within the debugfs > file system, which is typically located at /sys/kernel/debug/tracing. > For backward compatibility, when mounting the debugfs file system, > the tracefs file system will be automatically mounted at: > > /sys/kernel/debug/tracing > > Many comments and samples in the bpf code still refer to this older > debugfs path, so let's update them to avoid confusion. There are a few > spots where the bpf code explicitly checks both tracefs and debugfs > (tools/bpf/bpftool/tracelog.c and tools/lib/api/fs/fs.c) and I've left > those alone so that the tools can continue to work with both paths. > > Signed-off-by: Ross Zwisler > Acked-by: Michael S. Tsirkin Reviewed-by: Steven Rostedt (Google) -- Steve