MIME-Version: 1.0
References: <20230310184201.1302232-1-ajye_huang@compal.corp-partner.google.com>
 <0456bd4e-cfee-b863-e02d-98084b5da0f6@linux.intel.com> <CALprXBamM-M-YdyfX9dQHp_AQAovcqzL5H4rMPsZPXS426+VgA@mail.gmail.com>
 <a5962d12-ccd2-79ea-27bc-674e0b3065f4@linux.intel.com>
In-Reply-To: <a5962d12-ccd2-79ea-27bc-674e0b3065f4@linux.intel.com>
From:   Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Date:   Sat, 11 Mar 2023 07:55:21 +0800
Message-ID: <CALprXBYVFWDFkT5tnrj6Ef=+ibFLoBAnCnBHtZwSThDauN=uzw@mail.gmail.com>
Subject: Re: [PATCH v1] ASoC: Intel: sof_rt5682: Enable Bluetooth offload on adl_rt1019_rt5682
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Brent Lu <brent.lu@intel.com>,
        Yong Zhi <yong.zhi@intel.com>, dharageswari.r@intel.com,
        Vamshi Krishna <vamshi.krishna.gopal@intel.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        alsa-devel@alsa-project.org, Mac Chiang <mac.chiang@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Mar 11, 2023 at 6:46=E2=80=AFAM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>

> It's best if you provide a series that enables BT offload across the
> board for ADL, if that's the intended goal.
Hi Pierre,

  {        .name =3D "adl_mx98357_rt5682",
        .driver_data =3D (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
                    SOF_RT5682_SSP_CODEC(0) |
                    SOF_SPEAKER_AMP_PRESENT |
                    SOF_RT5682_SSP_AMP(2) |
                    SOF_RT5682_NUM_HDMIDEV(4)),
    },
The "adl_mx98357_rt5682" is the sound card of the google "Brya" Board proje=
ct.
Because the SSP2 is used for the max98357 amplifier, so SSP2
bt_offload can't be enabled at the drv_name  "adl_mx98357_rt5682".
(The hardway layout I2S port2 connected to max98357 amplifier)

The other adl projects that enabled the bt_offload feature were
designed with ssp1 for amp, ssp2 for bt_offload based on pins
definition.
    {
        .name =3D "adl_rt1019_rt5682",
        .driver_data =3D (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
                    SOF_RT5682_SSP_CODEC(0) |
                    SOF_SPEAKER_AMP_PRESENT |
                    SOF_RT1019_SPEAKER_AMP_PRESENT |
                    SOF_RT5682_SSP_AMP(1) |
                    SOF_RT5682_NUM_HDMIDEV(4) |
                    SOF_BT_OFFLOAD_SSP(2) |
                    SOF_SSP_BT_OFFLOAD_PRESENT),
    },
thanks