Message-ID: <a5f943d0-1653-3269-32c1-d879bc333ded@linaro.org>
Date:   Sat, 11 Mar 2023 01:04:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230310214413.275054-1-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230310214413.275054-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10.03.2023 22:44, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
> 
>   drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Shouldn't this driver depend on OF?

Konrad
>  drivers/soc/qcom/qcom_gsbi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
> index 290bdefbf28a..f1742e5bddb9 100644
> --- a/drivers/soc/qcom/qcom_gsbi.c
> +++ b/drivers/soc/qcom/qcom_gsbi.c
> @@ -114,7 +114,7 @@ struct gsbi_info {
>  	struct regmap *tcsr;
>  };
>  
> -static const struct of_device_id tcsr_dt_match[] = {
> +static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
>  	{ .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
>  	{ .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
>  	{ .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},