From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'James E.J. Bottomley'" <jejb@linux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@oracle.com>,
        "'Manivannan Sadhasivam'" <mani@kernel.org>,
        "'Andy Gross'" <agross@kernel.org>,
        "'Bjorn Andersson'" <andersson@kernel.org>,
        "'Konrad Dybcio'" <konrad.dybcio@linaro.org>,
        <linux-scsi@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
In-Reply-To: <20230310214435.275127-2-krzysztof.kozlowski@linaro.org>
Subject: RE: [PATCH 2/3] ufs: exynos: drop of_match_ptr for ID table
Date:   Sat, 11 Mar 2023 07:33:38 +0530
Message-ID: <000001d953bd$b3b099c0$1b11cd40$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJBeF328n03Zy3knz/Oyu2u3S3OAAGgvl5mAcbfUW6uCU0dQA==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230310214435.275127-1-krzysztof.kozlowski@linaro.org>
        <CGME20230310214444epcas5p19f82f433948288464f1c63d97eaa9110@epcas5p1.samsung.com>
        <20230310214435.275127-2-krzysztof.kozlowski@linaro.org>
Precedence: bulk

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: Saturday, March 11, 2023 3:15 AM
> To: Alim Akhtar <alim.akhtar=40samsung.com>; James E.J. Bottomley
> <jejb=40linux.ibm.com>; Martin K. Petersen <martin.petersen=40oracle.com>=
;
> Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>; Manivannan Sadhas=
ivam
> <mani=40kernel.org>; Andy Gross <agross=40kernel.org>; Bjorn Andersson
> <andersson=40kernel.org>; Konrad Dybcio <konrad.dybcio=40linaro.org>; lin=
ux-
> scsi=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-sam=
sung-
> soc=40vger.kernel.org; linux-kernel=40vger.kernel.org; linux-arm-
> msm=40vger.kernel.org
> Subject: =5BPATCH 2/3=5D ufs: exynos: drop of_match_ptr for ID table
>=20
> The driver can match only via the DT table so the table should be always =
used
> and the of_match_ptr does not have any sense (this also allows ACPI match=
ing
> via PRP0001, even though it is not relevant here).
>=20
>   drivers/ufs/host/ufs-exynos.c:1738:34: error: =E2=80=98exynos_ufs_of_ma=
tch=E2=80=99=20defined=0D=0A>=20but=20not=20used=20=5B-Werror=3Dunused-cons=
t-variable=3D=5D=0D=0A>=20=0D=0A>=20Signed-off-by:=20Krzysztof=20Kozlowski=
=20<krzysztof.kozlowski=40linaro.org>=0D=0A>=20---=0D=0A=0D=0AReviewed-by:=
=20Alim=20Akhtar=20<alim.akhtar=40samsung.com>=0D=0A=0D=0A>=20=20drivers/uf=
s/host/ufs-exynos.c=20=7C=202=20+-=0D=0A>=20=201=20file=20changed,=201=20in=
sertion(+),=201=20deletion(-)=0D=0A>=20=0D=0A>=20diff=20--git=20a/drivers/u=
fs/host/ufs-exynos.c=20b/drivers/ufs/host/ufs-exynos.c=20index=0D=0A>=207c9=
85fc38db1..0bf5390739e1=20100644=0D=0A>=20---=20a/drivers/ufs/host/ufs-exyn=
os.c=0D=0A>=20+++=20b/drivers/ufs/host/ufs-exynos.c=0D=0A>=20=40=40=20-1761=
,7=20+1761,7=20=40=40=20static=20struct=20platform_driver=20exynos_ufs_pltf=
orm=20=3D=20=7B=0D=0A>=20=20=09.driver=09=3D=20=7B=0D=0A>=20=20=09=09.name=
=09=3D=20=22exynos-ufshc=22,=0D=0A>=20=20=09=09.pm=09=3D=20&exynos_ufs_pm_o=
ps,=0D=0A>=20-=09=09.of_match_table=20=3D=20of_match_ptr(exynos_ufs_of_matc=
h),=0D=0A>=20+=09=09.of_match_table=20=3D=20exynos_ufs_of_match,=0D=0A>=20=
=20=09=7D,=0D=0A>=20=20=7D;=0D=0A>=20=20module_platform_driver(exynos_ufs_p=
ltform);=0D=0A>=20--=0D=0A>=202.34.1=0D=0A=0D=0A=0D=0A