Subject: Re: Possible kernel fs block code regression in 6.2.3 umounting usb
 drives
To:     Genes Lists <lists@sapience.com>, Jens Axboe <axboe@kernel.dk>,
        Eric Biggers <ebiggers@kernel.org>,
        Mike Cloaked <mike.cloaked@gmail.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, "yukuai (C)" <yukuai3@huawei.com>
References: <CAOCAAm7AEY9tkZpu2j+Of91fCE4UuE_PqR0UqNv2p2mZM9kqKw@mail.gmail.com>
 <CAOCAAm4reGhz400DSVrh0BetYD3Ljr2CZen7_3D4gXYYdB4SKQ@mail.gmail.com>
 <ZAuPkCn49urWBN5P@sol.localdomain> <ZAuQOHnfa7xGvzKI@sol.localdomain>
 <ad021e89-c05c-f85a-2210-555837473734@kernel.dk>
 <88b36c03-780f-61a5-4a66-e69072aa7536@sapience.com>
From:   Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <8acad7a9-4ecc-7985-ebbe-932e6db41cd9@huaweicloud.com>
Date:   Sat, 11 Mar 2023 10:07:54 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <88b36c03-780f-61a5-4a66-e69072aa7536@sapience.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2023/03/11 5:08, Genes Lists 写道:
> On 3/10/23 15:23, Jens Axboe wrote:
>> On 3/10/23 1:16 PM, Eric Biggers wrote:
> ...
>> But I would revert:
>>
>> bfe46d2efe46c5c952f982e2ca94fe2ec5e58e2a
>> 57a425badc05c2e87e9f25713e5c3c0298e4202c
>>
>> in that order from 6.2.3 and see if that helps. Adding Yu.

So, The reason is that patch dfd6200a0954 ("blk-cgroup: support to track
if policy is online") is missed, this will absolutely cause some
problems.

Thanks,
Kuai
>>
> Confirm the 2 Reverts fixed in my tests as well (nvme + sata drives).
> Nasty crash - some needed to be power cycled as they hung on shutdown.
> 
> Thank you!
> 
> gene
> 
> 
> .
>