Return-Path: <linux-kernel-owner+w=401wt.eu-S1754678AbXIOWgR@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754678AbXIOWgR (ORCPT <rfc822;w@1wt.eu>);
	Sat, 15 Sep 2007 18:36:17 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751954AbXIOWgG
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 15 Sep 2007 18:36:06 -0400
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46938
	"EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK)
	by vger.kernel.org with ESMTP id S1751542AbXIOWgF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 15 Sep 2007 18:36:05 -0400
Date: Sat, 15 Sep 2007 15:36:02 -0700 (PDT)
Message-Id: <20070915.153602.74747413.davem@davemloft.net>
To: vonbrand@inf.utfsm.cl
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: SPARC{,64}: kernel_termios_to_user_termios_1 missing
From: David Miller <davem@davemloft.net>
In-Reply-To: <200709152137.l8FLbtXP001446@laptop13.inf.utfsm.cl>
References: <200709152137.l8FLbtXP001446@laptop13.inf.utfsm.cl>
X-Mailer: Mew version 5.1.52 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1969
Lines: 58

From: "Horst H. von Brand" <vonbrand@inf.utfsm.cl>
Date: Sat, 15 Sep 2007 17:37:55 -0400

> git-describe says this is v2.6.23-rc6-168-g53a3f30
> I'm getting:
> 
>   drivers/char/tty_ioctl.c: In function 'n_tty_ioctl':
>   drivers/char/tty_ioctl.c:799: error: implicit declaration of function 'kernel_termios_to_user_termios_1'
> 
> This is a macro at the very end of include/asm-<foo>/termios.h for i686, on
> SPARC and SPARC64 it is missing. Sorry, I've got no clue on how to define
> this correctly here.
> 
> It is also missing on alpha, blackfin, parisc, sh64, sh, xtensa

This has been reported and discussed extensively on the lists
over the past 4 or 5 days.

It is a well known issue, and if you just need to get the sparc64
build working so you can test it out just use the patch below:

diff --git a/include/asm-sparc/termios.h b/include/asm-sparc/termios.h
index d767f20..25e9cbb 100644
--- a/include/asm-sparc/termios.h
+++ b/include/asm-sparc/termios.h
@@ -142,6 +142,11 @@ struct winsize {
 	0; \
 })
 
+#define user_termios_to_kernel_termios_1(k, u) \
+	user_termios_to_kernel_termios(k, u)
+#define kernel_termios_to_user_termios_1(u, k) \
+	kernel_termios_to_user_termios(u, k)
+
 #endif	/* __KERNEL__ */
 
 #endif /* _SPARC_TERMIOS_H */
diff --git a/include/asm-sparc64/termios.h b/include/asm-sparc64/termios.h
index f05d390..6fc71e6 100644
--- a/include/asm-sparc64/termios.h
+++ b/include/asm-sparc64/termios.h
@@ -145,6 +145,11 @@ struct winsize {
 	err; \
 })
 
+#define user_termios_to_kernel_termios_1(k, u) \
+	user_termios_to_kernel_termios(k, u)
+#define kernel_termios_to_user_termios_1(u, k) \
+	kernel_termios_to_user_termios(u, k)
+
 #endif	/* __KERNEL__ */
 
 #endif /* _SPARC64_TERMIOS_H */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/