Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFEDC61DA4 for ; Sat, 11 Mar 2023 09:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjCKJaD (ORCPT ); Sat, 11 Mar 2023 04:30:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbjCKJ3z (ORCPT ); Sat, 11 Mar 2023 04:29:55 -0500 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D066227B6 for ; Sat, 11 Mar 2023 01:29:53 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id E617961989E6; Sat, 11 Mar 2023 10:29:50 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3g_el_QkYBeq; Sat, 11 Mar 2023 10:29:49 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id CA1EA61989EA; Sat, 11 Mar 2023 10:29:49 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0uJFQxCAaqwE; Sat, 11 Mar 2023 10:29:49 +0100 (CET) Received: from blindfold.corp.sigma-star.at (089144204221.atnat0013.highway.webapn.at [89.144.204.221]) by lithops.sigma-star.at (Postfix) with ESMTPSA id 03ECF61989E6; Sat, 11 Mar 2023 10:29:48 +0100 (CET) From: Richard Weinberger To: linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Richard Weinberger , Daniel Palmer , Linus Torvalds , Christoph Hellwig Subject: [PATCH] ubi: block: Fix missing blk_mq_end_request Date: Sat, 11 Mar 2023 10:29:29 +0100 Message-Id: <20230311092929.2827-1-richard@nod.at> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Switching to BLK_MQ_F_BLOCKING wrongly removed the call to blk_mq_end_request(). Add it back to have our IOs finished Cc: Daniel Palmer Cc: Linus Torvalds Cc: Christoph Hellwig Fixes: 91cc8fbcc8c7 ("ubi: block: set BLK_MQ_F_BLOCKING") Analyzed-by: Linus Torvalds Reported-by: Daniel Palmer Link: https://lore.kernel.org/linux-mtd/CAHk-=3Dwi29bbBNh3RqJKu3PxzpjDN5D= 5K17gEVtXrb7-6bfrnMQ@mail.gmail.com/ Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/block.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c index 1de87062c67b..3711d7f74600 100644 --- a/drivers/mtd/ubi/block.c +++ b/drivers/mtd/ubi/block.c @@ -221,7 +221,10 @@ static blk_status_t ubiblock_read(struct request *re= q) =20 rq_for_each_segment(bvec, req, iter) flush_dcache_page(bvec.bv_page); - return errno_to_blk_status(ret); + + blk_mq_end_request(req, errno_to_blk_status(ret)); + + return BLK_STS_OK; } =20 static int ubiblock_open(struct block_device *bdev, fmode_t mode) --=20 2.26.2