From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     masahiroy@kernel.org
Cc:     adobriyan@gmail.com, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] menuconfig: reclaim vertical space
Date:   Sat, 11 Mar 2023 14:42:48 +0300
Message-Id: <20230311114248.36587-3-adobriyan@gmail.com>
In-Reply-To: <20230311114248.36587-1-adobriyan@gmail.com>
References: <20230311114248.36587-1-adobriyan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Menuconfig has lots of vertical space wasted: on my system there are
17 lines of useful information about config options and 14 lines of
useless fluff: legend, horizontal separators and shadows.

Sitation is even worse on smaller terminals because fixed vertical
lines do not go away, but config option lines do, further decreasing
informational density. Minimum reasonable 80×24 text console has only
10(!) lines of menus presented which is less than half of the screen.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
 scripts/kconfig/lxdialog/menubox.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
index 5eb67c04821f..dc608914c636 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -183,14 +183,14 @@ int dialog_menu(const char *title, const char *prompt,
 	if (height < MENUBOX_HEIGTH_MIN || width < MENUBOX_WIDTH_MIN)
 		return -ERRDISPLAYTOOSMALL;
 
-	height -= 4;
+	height -= 2;
 	menu_height = height - 10;
 
 	max_choice = MIN(menu_height, item_count());
 
 	/* center dialog box on screen */
-	x = (getmaxx(stdscr) - width) / 2;
-	y = (getmaxy(stdscr) - height) / 2;
+	x = 0;
+	y = 2;
 
 	dialog = newwin(height, width, y, x);
 	keypad(dialog, TRUE);
-- 
2.39.2