Message-ID: <6b7239e3-81f6-067e-1fd2-9dc62166d4da@gmx.de>
Date:   Sat, 11 Mar 2023 12:57:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH -next] fbdev/clps711x-fb: Use
 devm_platform_get_and_ioremap_resource()
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230308054950.15164-1-yang.lee@linux.alibaba.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230308054950.15164-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:+ljmdtxQlKg=;BGKjGEsuVgcQ9eJ9p5eEuzOXbw/
 HRBk+u/7qxQNMysDpxo3U+nJyvrlBgNdjH9AzoMesr+sZEJg8gQx0Bi+OyAskvIoRSqdmaQ/b
 oroA8OkSpLFzvQ+erwOhMyGU1fvRm+6zT/pT//7x8pcqjPjzXvaJnuyITSCQR0i1ns4ACapSi
 01ZwFBAGccDFs1+PzK7gcsdBmGr8pCgfnmreOKLYGNBIwd+nw7C49K1oTEJ+maFAcTpmSn/Rd
 uqZr+i30ASUVF5RejcoJKqZbtK513pG9BEJBOlCkWPwyN4rnKGQfa4QjoQC+8thM0/DYMgXxc
 JAg8sX9qHEjmwUpNaMNxnJTYXqi6mZXwqTqy53yQWRNC89b2dMLXkiXoYyvkNn3CBoGZ+zhi5
 YoT9UeUXvPE29j2+GmGPV7mr0z1BCqZvoYvuWvG5HzAkw94vlO+fhT8IAUGcxSvMo1cMC7Qow
 ddmEFxHIt6nWsrxKBqnmGjDbEN4z3Uk0nsAqzE5dNExlofU5powy9SizFYD/pC+WYFxMG4cx9
 tJJl/xS24JOPPPw1ku9ghjl9jBhMN59CZ/hFupNtHQsHnmWUyk0j5AI+TI8IOKEhDcFH2c8Gh
 IrAUKligIdvSYfDEWKk4XPnotMlmcAiS2Ra0lPI+jNDCnErtsS/DNyEmECeN+zLIb+G1A1N1N
 XtZM6GTvoe35IBF0IdfnTGrupoilHhQorTRiB6dAqdG5NaO8Q8zvwwMwxMBL/wd/DHPwPeHSE
 4+viCXqMv4Kh44R91jH+QkrnbFnV0Zl10J+4p3sn5wz1Qm0IL7taBB0ZADjYTKD05qgOqSbJE
 bsMjd2S9xq+LtDY2LGiDnpEKmjLXoOsPco7HEkBMMbzohNCh06HOf6GXVCIqQYNEoO6005Hn3
 Ng76rGWMvymT/o4gSE5Nq9HigG6yA0UtHm/xInOP3coDCKfnmVpXGODYP0avPZ8czG6BCmaKk
 We0NTw==
Precedence: bulk

On 3/8/23 06:49, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/clps711x-fb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clp=
s711x-fb.c
> index 45c75ff01eca..c8bfc608bd9c 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -238,8 +238,7 @@ static int clps711x_fb_probe(struct platform_device =
*pdev)
>   	info->fix.mmio_start =3D res->start;
>   	info->fix.mmio_len =3D resource_size(res);
>
> -	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	info->screen_base =3D devm_ioremap_resource(dev, res);
> +	info->screen_base =3D devm_platform_get_and_ioremap_resource(pdev, 1, =
&res);
>   	if (IS_ERR(info->screen_base)) {
>   		ret =3D PTR_ERR(info->screen_base);
>   		goto out_fb_release;