Date:   Sat, 11 Mar 2023 13:55:19 +0100 (CET)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
cc:     outreachy@lists.linux.dev, vireshk@kernel.org, johan@kernel.org,
        elder@kernel.org, gregkh@linuxfoundation.org,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis
In-Reply-To: <71211670-60f9-11f4-1ee7-f94d4d9df4fb@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2303111354490.2802@hadrien>
References: <b6521b9a75a4088d621246b436c7ec5d35365690.1678462486.git.eng.mennamahmoud.mm@gmail.com> <alpine.DEB.2.22.394.2303110958250.2802@hadrien> <71211670-60f9-11f4-1ee7-f94d4d9df4fb@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-602893840-1678539319=:2802"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-602893840-1678539319=:2802
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT


On Sat, 11 Mar 2023, Menna Mahmoud wrote:

>
> On ١١/٣/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
> >
> > On Fri, 10 Mar 2023, Menna Mahmoud wrote:
> >
> > > Fix " CHECK: Alignment should match open parenthesis "
> > > Reported by checkpath
> > See the message in the other mail about the log message.
> >
> > Also, you should not have two patches with the same subject.  Here, the
> > changes are on the same file and are essentially the same, even involving
> > the same function call.  So they can be together in one patch.
> >
> > julia
> okay, I will. appreciate your feedback. thanks.

Please put some blank lines around your response, so it is easier to find.

thanks,
julia

> >
> > > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
> > > ---
> > >   drivers/staging/greybus/fw-core.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/greybus/fw-core.c
> > > b/drivers/staging/greybus/fw-core.c
> > > index 57bebf24636b..f562cb12d5ad 100644
> > > --- a/drivers/staging/greybus/fw-core.c
> > > +++ b/drivers/staging/greybus/fw-core.c
> > > @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle,
> > >   			}
> > >
> > >   			connection = gb_connection_create(bundle, cport_id,
> > > -						gb_fw_mgmt_request_handler);
> > > +
> > > gb_fw_mgmt_request_handler);
> > >   			if (IS_ERR(connection)) {
> > >   				ret = PTR_ERR(connection);
> > >   				dev_err(&bundle->dev,
> > > --
> > > 2.34.1
> > >
> > >
> > >
>
--8323329-602893840-1678539319=:2802--