Date:   Sat, 11 Mar 2023 08:57:02 -0500
From:   William Breathitt Gray <william.gray@linaro.org>
To:     jic23@kernel.org, lars@metafoo.de
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] iio: dac: cio-dac: Migrate to the regmap API
Message-ID: <ZAyIrrLrhmMJqq2w@fedora>
References: <20230311134012.70822-1-william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7eaGiRj104sy96DY"
Content-Disposition: inline
In-Reply-To: <20230311134012.70822-1-william.gray@linaro.org>
Precedence: bulk


--7eaGiRj104sy96DY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 11, 2023 at 08:40:12AM -0500, William Breathitt Gray wrote:
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver.
>=20
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>

[...]

> @@ -117,8 +148,12 @@ static int cio_dac_probe(struct device *dev, unsigne=
d int id)
>  	indio_dev->name =3D dev_name(dev);
> =20
>  	/* initialize DAC outputs to 0V */
> -	for (i =3D 0; i < CIO_DAC_NUM_CHAN; i++)
> -		iowrite16(0, priv->base + i);
> +	for (i =3D 0; i < CIO_DAC_NUM_CHAN; i++) {
> +		offset =3D i * CIO_DAC_CHANNEL_STRIDE;
> +		err =3D regmap_write(priv->map, CIO_DAC_BASE + offset, 0);
> +		if (err)
> +			return err;
> +	}
> =20
>  	return devm_iio_device_register(dev, indio_dev);
>  }

As soon as I sent this I realized this last hunk is no longer necessary
because the chan_out_states array is gone so we don't need to match its
initialized state. I'll remove this block as superfluous and submit a v2
patch shortly.

William Breathitt Gray

--7eaGiRj104sy96DY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZAyIrgAKCRC1SFbKvhIj
K1z2AQCXC7YVVHrA7LJgDJsARq//xniX0yAewpIY+ix0wlp33QD9He4DCxaHI52t
Q4te1JECKhcAK2HyQaQcA7JQMK/j+A8=
=btlL
-----END PGP SIGNATURE-----

--7eaGiRj104sy96DY--