Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7953C61DA4 for ; Sat, 11 Mar 2023 14:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbjCKOtI (ORCPT ); Sat, 11 Mar 2023 09:49:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjCKOtG (ORCPT ); Sat, 11 Mar 2023 09:49:06 -0500 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 008E010EAA8; Sat, 11 Mar 2023 06:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=mnBoXWCWc8GTA6EussKi3kzGkFsly/2hTA8VBPAoaQo=; b=jodawiDvrX0oP7vrwzWvZWWHyISWGU7N221Bf9fAM+a5K2zt8hATeL8m Der+1hrP4LfSfoMp+gKNeBpyzDCOovSIOEzhTcZihqQeqfa6yc7deY66f ZJYniCDvlqlaWdQvZ+C76N0G9LR/3edqBmXULOTSX3KW3i8WevMt7pODE U=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.98,252,1673910000"; d="scan'208";a="96649826" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2023 15:49:03 +0100 Date: Sat, 11 Mar 2023 15:49:03 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Sumitra Sharma cc: error27@gmail.com, GR-Linux-NIC-Dev@marvell.com, coiby.xu@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, manishc@marvell.com, netdev@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] Staging: qlge: Remove parenthesis around single condition In-Reply-To: <20230311144318.GC14247@ubuntu> Message-ID: References: <20230311144318.GC14247@ubuntu> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Mar 2023, Sumitra Sharma wrote: > Hi Dan, > > Your suggestion for correcting the indentation to > "[tab][tab][space][space][space][space](i ==." conflicts with the > statement "Outside of comments, documentation and except in Kconfig, > spaces are never used for indentation" written in > https://elixir.bootlin.com/linux/latest/source/Documentation/process/coding-style.rst You can use spaces at the end of an indentation if it allows lining up things with a similar purpose. Look around at other examples of kernel code, outside of staging, to see what others have done. julia