Message-ID: <fe97c33f-536a-5951-73bd-169b67d9b8d8@gmail.com>
Date:   Sat, 11 Mar 2023 16:58:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis
Content-Language: en-US
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     outreachy@lists.linux.dev, vireshk@kernel.org, johan@kernel.org,
        elder@kernel.org, gregkh@linuxfoundation.org,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <b6521b9a75a4088d621246b436c7ec5d35365690.1678462486.git.eng.mennamahmoud.mm@gmail.com>
 <alpine.DEB.2.22.394.2303110958250.2802@hadrien>
 <71211670-60f9-11f4-1ee7-f94d4d9df4fb@gmail.com>
 <alpine.DEB.2.22.394.2303111354490.2802@hadrien>
 <61dab579-f10b-5538-8b61-ebe73ae5b4f1@gmail.com>
 <27dfe880-35f7-cbc1-cf8b-7bbd7f1c7301@gmail.com>
 <alpine.DEB.2.22.394.2303111537430.2802@hadrien>
From:   Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
In-Reply-To: <alpine.DEB.2.22.394.2303111537430.2802@hadrien>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On ١١‏/٣‏/٢٠٢٣ ١٦:٣٨, Julia Lawall wrote:
>
> On Sat, 11 Mar 2023, Menna Mahmoud wrote:
>
>> On ١١/٣/٢٠٢٣ ١٤:٥٧, Menna Mahmoud wrote:
>>> On ١١/٣/٢٠٢٣ ١٤:٥٥, Julia Lawall wrote:
>>>> On Sat, 11 Mar 2023, Menna Mahmoud wrote:
>>>>
>>>>> On ١١/٣/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
>>>>>> On Fri, 10 Mar 2023, Menna Mahmoud wrote:
>>>>>>
>>>>>>> Fix " CHECK: Alignment should match open parenthesis "
>>>>>>> Reported by checkpath
>>>>>> See the message in the other mail about the log message.
>>>>>>
>>>>>> Also, you should not have two patches with the same subject.  Here,
>>>>>> the
>>>>>> changes are on the same file and are essentially the same, even
>>>>>> involving
>>>>>> the same function call.  So they can be together in one patch.
>>>>>>
>>>>>> julia
>>>>> okay, I will. appreciate your feedback. thanks.
>>>> Please put some blank lines around your response, so it is easier to find.
>>>>
>>>> thanks,
>>>> julia
>>>
>>> Okay, I will.
>>>
>>> thanks,
>>>
>>> Menna
>>
>>
>> Hi Julia,
>>
>> according to Alex feedback
>>
>> " I think this type of alignment is not a major problem,
>> and alignment isn't done this way in general in this
>> driver, it's probably OK to keep it that way. - Alex "
>>
>>
>> ,I won't resubmit these patches, right?
> The existing code indeed looks better to me.  So you can skip this issue.
>
> julia


Okay, thanks Julia.


>
>>
>>   -Menna
>>
>>
>>>
>>>>>>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>>>>>>> ---
>>>>>>>     drivers/staging/greybus/fw-core.c | 2 +-
>>>>>>>     1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/drivers/staging/greybus/fw-core.c
>>>>>>> b/drivers/staging/greybus/fw-core.c
>>>>>>> index 57bebf24636b..f562cb12d5ad 100644
>>>>>>> --- a/drivers/staging/greybus/fw-core.c
>>>>>>> +++ b/drivers/staging/greybus/fw-core.c
>>>>>>> @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle
>>>>>>> *bundle,
>>>>>>>                 }
>>>>>>>
>>>>>>>                 connection = gb_connection_create(bundle, cport_id,
>>>>>>> -                        gb_fw_mgmt_request_handler);
>>>>>>> +
>>>>>>> gb_fw_mgmt_request_handler);
>>>>>>>                 if (IS_ERR(connection)) {
>>>>>>>                     ret = PTR_ERR(connection);
>>>>>>>                     dev_err(&bundle->dev,
>>>>>>> --
>>>>>>> 2.34.1
>>>>>>>
>>>>>>>
>>>>>>>
> >