Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2B5C61DA4 for ; Sat, 11 Mar 2023 17:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbjCKROR (ORCPT ); Sat, 11 Mar 2023 12:14:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229942AbjCKROO (ORCPT ); Sat, 11 Mar 2023 12:14:14 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 708E4B690F for ; Sat, 11 Mar 2023 09:14:12 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id x11so8737352pln.12 for ; Sat, 11 Mar 2023 09:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678554851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TOKGow/mO9jpNc8gyiIeqT76HvA8+ciKGvap6neQtLg=; b=yJiZLQha3nB0hAHFQp9VXnUdnoUsZXC5K7tGx+JqI7BAu7IJSR1x7U7FVPH8s74TqT DXt8PvA9yA+OaReqJwnXYsUWaafY8MfasdQ+hEisuk+NXAoTQ7QOQlFTIchEO2CIa3M2 3D5oXzqnvdXjaYdX5lxaZmVqDPbGfDvA2JCayXcm7QyfyzcHID/lpQBgqnoAvxNZgT4E 642nH9+0Sd+7BoY3rly6+o4UEAQ3UXJysbkIAko3GHApXkiEWy7PbFFpD6jLBLFae0XA BmuT6eJPSJYSblVOzuT5ZJcpaKMrcc/3GZ6wMPUq0ry6dKtdWQwscP6tVRlF3S2kskch hu3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678554851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TOKGow/mO9jpNc8gyiIeqT76HvA8+ciKGvap6neQtLg=; b=Xq591EnTMwnYz8HA2oDOjKGEz+XZ4Eztu/aFJJ/wiVaSyADFny2fcYLJuiPJgTjV4N YYbmCw+jWEflWKo5NQuWEIkPeR2K8c6sKQ3LirL42GUyposFeD7TM/uT8Gh+cavGlI3r BV0dWxDpVEGe/bN0H4xhyyfTEz+OY1x5UXs1GCi5hWfY/lUKUN1yE8O6eMkd5Yf6NqK9 JZuV/q+tYy7xeRazDzKd6HnNx7PkQjry+1oySK6NdfJlTpV5yweXUlyqX1sUvJudVgfy FtMTj3hzHcU7YHypwJvJ+yL95RUH23pgxqvoreFwQGancwiZv5E2Q9FbMMKcx4fQZN5n HK3A== X-Gm-Message-State: AO0yUKXUUckmwYHVPCDsUiUiISWsO1wv3RDow2COipBluhZsAgQU+s5G zJ9g/c5KYyEPdpU1iU5QFMoCdA== X-Google-Smtp-Source: AK7set+P2NvIbojvM+8gOZPt4aOld2GWsyXU4p7Q06ZatC0junkHBHw7lV2yhgvk/Q9jJm+KfBHlTQ== X-Received: by 2002:a17:903:1c1:b0:19e:72c5:34df with SMTP id e1-20020a17090301c100b0019e72c534dfmr34384572plh.52.1678554851742; Sat, 11 Mar 2023 09:14:11 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ld14-20020a170902face00b0019f387f2dc3sm198752plb.24.2023.03.11.09.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 09:14:11 -0800 (PST) Date: Sat, 11 Mar 2023 09:14:09 -0800 From: Stephen Hemminger To: Jason Xing Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, kuniyu@amazon.com, liuhangbin@gmail.com, xiangxia.m.yue@gmail.com, jiri@nvidia.com, andy.ren@getcruise.com, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Xing Subject: Re: [PATCH net-next] net: introduce budget_squeeze to help us tune rx behavior Message-ID: <20230311091409.4f125e53@hermes.local> In-Reply-To: <20230311163614.92296-1-kerneljasonxing@gmail.com> References: <20230311163614.92296-1-kerneljasonxing@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Mar 2023 00:36:14 +0800 Jason Xing wrote: > - for (;;) { > + for (; is_continue;) { Easier to read this as a while (is_continue) { but what is wrong with using break; instead?