Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B38FC61DA4 for ; Sat, 11 Mar 2023 17:33:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbjCKRdf (ORCPT ); Sat, 11 Mar 2023 12:33:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbjCKRdT (ORCPT ); Sat, 11 Mar 2023 12:33:19 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F2BC136C6 for ; Sat, 11 Mar 2023 09:33:15 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id j11so33033876edq.4 for ; Sat, 11 Mar 2023 09:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678555993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HZxuVpVebsRRraysHVEtopW/pRW+n6rrpYSxL3G7TSA=; b=tMKPN/0O5hiExIQzmUdM/nd3i2G0ghQ+pin+O8uUESJmlR1h3DD8OvmvNZEBkC8BFx rBh8zgXrwH3RArTVe8yXftf6Ar3BxqZSycY/MjqnkK9QaNOVsTBky3K8qo+yjWoWB3HT DXqU5AQPyxMwkaEMgypUS3ERBToIKsBxAWG5OkI9FbvEFqDpRtwsemVTrdxVZ4D4EGoa iP6IoifCjqOvmbr+ad57xelqN3xTwF/hyP8pJDoUjm7O/rC+tKbu8sFwi2/p0k9qOyiU 5uYOHVUrT0q6s9o9p9Y2zuMKKq+IXGYtW5EUo6PVnwyXdtba9YBdmp7VQP9P3zrIeMMj oT/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678555993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HZxuVpVebsRRraysHVEtopW/pRW+n6rrpYSxL3G7TSA=; b=b2S1ZrzbHSO11FruODzerX9rlTIYFL6VZcUAWPESyy84hCffgFWgtggxUtG44x0VT+ 0dOLGTH8EYa1LCblWgNyGjjEL9oFUqRxWRfyRSkYFgdnGThA8X4r+N1tIy50vQ8g8V0i LUNjKeBunyW4sHvrXPi0Yjak1e/weqVYqmOVftiRkr/s8ftpmB6EyBD2VtGvuYz3eai2 /uut30nm360a4+TCEDC/XwmyclGDYOmOKSEt2n+AvliGHNrH6yo6aaMnjP2rRkBBsQHT bYZMq7xio/QmUJO2B8gWg5x9nLIlm694S2g3ij94DMrLglAUMaXNdrxAgPZ2ZHKW59M8 aayA== X-Gm-Message-State: AO0yUKUeAqRjU7bDeXXox01ZgkkU+3maO8cbKgd6oH5aD2YeB792RLrf tw0As0LB9LrHhiWAG9cTo7vjwg== X-Google-Smtp-Source: AK7set+YXBuxIPUkydQd5TySLdyku2ej4p0a0d6fGBoTL1fEL0/yj69k0x70JsFAUDGnbbvJtselrA== X-Received: by 2002:a50:ee92:0:b0:4fb:2060:4c24 with SMTP id f18-20020a50ee92000000b004fb20604c24mr1127782edr.4.1678555993534; Sat, 11 Mar 2023 09:33:13 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:6927:e94d:fc63:9d6e]) by smtp.gmail.com with ESMTPSA id k15-20020a50ce4f000000b004d8287c775fsm1440885edj.8.2023.03.11.09.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 09:33:13 -0800 (PST) From: Krzysztof Kozlowski To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Claudiu Manoil , Alexandre Belloni , Colin Foster , Michael Hennerich , Alexander Aring , Stefan Schmidt , Miquel Raynal , Heiner Kallweit , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/12] net: dsa: lan9303: drop of_match_ptr for ID table Date: Sat, 11 Mar 2023 18:32:53 +0100 Message-Id: <20230311173303.262618-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230311173303.262618-1-krzysztof.kozlowski@linaro.org> References: <20230311173303.262618-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver will match mostly or only by DT table (even thought there is regular ID table) so there is little benefit in of_match_ptr (this also allows ACPI matching via PRP0001, even though it might not be relevant here). drivers/net/dsa/lan9303_i2c.c:97:34: error: ‘lan9303_i2c_of_match’ defined but not used [-Werror=unused-const-variable=] drivers/net/dsa/lan9303_mdio.c:157:34: error: ‘lan9303_mdio_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/net/dsa/lan9303_i2c.c | 2 +- drivers/net/dsa/lan9303_mdio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/lan9303_i2c.c b/drivers/net/dsa/lan9303_i2c.c index 1cb41c36bd47..e8844820c3a9 100644 --- a/drivers/net/dsa/lan9303_i2c.c +++ b/drivers/net/dsa/lan9303_i2c.c @@ -103,7 +103,7 @@ MODULE_DEVICE_TABLE(of, lan9303_i2c_of_match); static struct i2c_driver lan9303_i2c_driver = { .driver = { .name = "LAN9303_I2C", - .of_match_table = of_match_ptr(lan9303_i2c_of_match), + .of_match_table = lan9303_i2c_of_match, }, .probe_new = lan9303_i2c_probe, .remove = lan9303_i2c_remove, diff --git a/drivers/net/dsa/lan9303_mdio.c b/drivers/net/dsa/lan9303_mdio.c index 4f33369a2de5..d8ab2b77d201 100644 --- a/drivers/net/dsa/lan9303_mdio.c +++ b/drivers/net/dsa/lan9303_mdio.c @@ -164,7 +164,7 @@ MODULE_DEVICE_TABLE(of, lan9303_mdio_of_match); static struct mdio_driver lan9303_mdio_driver = { .mdiodrv.driver = { .name = "LAN9303_MDIO", - .of_match_table = of_match_ptr(lan9303_mdio_of_match), + .of_match_table = lan9303_mdio_of_match, }, .probe = lan9303_mdio_probe, .remove = lan9303_mdio_remove, -- 2.34.1