Date:   Sat, 11 Mar 2023 18:54:29 +0100
From:   Sebastian Reichel <sre@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCHv1 01/11] dt-bindings: power: supply: adc-battery: add
 binding
Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local>
References: <20230309225041.477440-1-sre@kernel.org>
 <20230309225041.477440-2-sre@kernel.org>
 <CACRpkdYWP7Fc3yho5nDB3qU6rt5o4p2Zcz_RxOvOfsAwjXgqXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="r33a6f5pdav5vdbc"
Content-Disposition: inline
In-Reply-To: <CACRpkdYWP7Fc3yho5nDB3qU6rt5o4p2Zcz_RxOvOfsAwjXgqXw@mail.gmail.com>
Precedence: bulk


--r33a6f5pdav5vdbc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Linus,

On Fri, Mar 10, 2023 at 09:14:39AM +0100, Linus Walleij wrote:
> Hi Sebastian,
>=20
> thanks for your patches!
>=20
> On Thu, Mar 9, 2023 at 11:50=E2=80=AFPM Sebastian Reichel <sre@kernel.org=
> wrote:
>=20
> > Add binding for a battery that is only monitored via ADC
> > channels and simple status GPIOs.
> >
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
>=20
> This does look very useful.

:)

> > +title: ADC battery
> > +
> > +maintainers:
> > +  - Sebastian Reichel <sre@kernel.org>
> > +
> > +description: |
> > +  Basic Battery, which only reports (in circuit) voltage and optionally
> > +  current via an ADC channel.
>=20
> I would over-specify: "voltage over the terminals" and
> "current out of the battery" so this cannot be misunderstood.
>=20
> + this text:
>=20
> It can also optionally indicate that the battery is full by pulling a GPIO
> line.

Ack.

>=20
> > +  charged-gpios:
> > +    description:
> > +      GPIO which signals that the battery is fully charged.
>=20
> It doesn't say how, I guess either this is an analog circuit (!) or
> a charger IC? If it doesn't matter, no big deal, but if something is
> implicit here, then spell it out please.

In my case the GPIO is provided by a charger chip, that is not
software controllable (just reports charge-done & charger-connected
via GPIOs). I've seen something similar in a customer device some
years ago. I will add a sentence:

The GPIO is often provided by charger ICs, that are not software
controllable.

> > +    fuel-gauge {
>=20
> This techno-lingo/slang term is a bit unfortunate, but if there are
> precedents then stick with it.
>=20
> The correct term could be something like battery-capacity-meter
> I suppose.

Right now in DT we have

 - specific node name (e.g. chip names) that should be changed :)
 - smart-battery
 - battery
 - fuel-gauge

I think fuel-gauge is the most sensible of that list, considering
hardware vendors usually call their chips battery fuel gauge.

-- Sebastian

--r33a6f5pdav5vdbc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQMwFEACgkQ2O7X88g7
+pr7kBAAmyDSM90DC1hkH6XIxMuE1dgd9pZvygODosBhLZzRDgo+eCiRmmpUHky4
5SpD/AK2vuptrYpv+p3yGrUorWUUE0kvNU0PMS5ID0CO7+6HOwALVhov1Mvk4oO5
a+WKYx4jV0t7FMvHe8GJ9r+ni4ywgCvRrAfVYIzHU67G+3pfURIc5SMh7UreQg+x
+Iies0ihL86aijszMhfsaX/0+zudlRa+dSwRZ9w72dqgvO0ksUNZl3bp2Z2/W6MR
OwbSUQmIBBxVVPs/1re18+F+GgxOkaghomxkLHLTF9shNtB5SRIqLDRi2Mszi6H2
Rmp8sQH4IDtKFC3EtJ1qCqRceTH/6tf+kNXSQ/8fw3pLZsLRy49DGsRshW5qaLm8
qRTZ8GU3XsbFGQgx1+GHSpzdCbTdH9Nbq+QsmETm2dl8HMFFGmMYSMWVUeixRWAx
tU2js6NhXJMEtl2MnjMeYUWWzKBLpDUN8AqPeMe/XvfG7RHmLjUHh8nwNqXxrZCk
7ttaRH4e8lJJNGkcbXDWQsMAaGNCBBl22GPwYNdVnE963p4BlpaPf85VzJbGmSR8
QmW2FuPueIv74B5HPzWUlfG2G4NN85NEmeUpXxfmr92iHbVr1DLLHKMjCxkbnecq
tPLCWhkdyD//zknvWI0+6nNuGNxx+XEhgJBLQR09jrTQtABciWc=
=MH4X
-----END PGP SIGNATURE-----

--r33a6f5pdav5vdbc--