Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S285059AbRLLCqx>; Tue, 11 Dec 2001 21:46:53 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S285056AbRLLCqn>; Tue, 11 Dec 2001 21:46:43 -0500
Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:58093 "EHLO
	fgwmail6.fujitsu.co.jp") by vger.kernel.org with ESMTP
	id <S285059AbRLLCqd>; Tue, 11 Dec 2001 21:46:33 -0500
Date: Wed, 12 Dec 2001 11:46:29 +0900
Message-ID: <wuzt40l6.wl@nisaaru.dvs.cs.fujitsu.co.jp>
From: Tachino Nobuhiro <tachino@open.nm.fujitsu.co.jp>
To: Linus Torvalds <torvalds@transmeta.com>, <marcelo@conectiva.com.br>
Cc: Tachino Nobuhiro <tachino@open.nm.fujitsu.co.jp>,
        GOTO Masanori <gotom@debian.org>, <linux-kernel@vger.kernel.org>,
        <andrea@suse.de>
Subject: Re: [PATCH] direct IO breaks root filesystem
In-Reply-To: <Pine.LNX.4.33.0112111742001.18126-100000@penguin.transmeta.com>
In-Reply-To: <y9k945x1.wl@nisaaru.dvs.cs.fujitsu.co.jp>
	<Pine.LNX.4.33.0112111742001.18126-100000@penguin.transmeta.com>
User-Agent: Wanderlust/2.7.6 (Too Funky) EMIKO/1.14.1 (Choanoflagellata) LIMIT/1.14.7 (Fujiidera) APEL/10.3 Emacs/21.1 (i586-kondara-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by EMIKO 1.14.1 - "Choanoflagellata")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 11 Dec 2001 17:46:01 -0800 (PST),
Linus Torvalds wrote:
> 
> 
> On Wed, 12 Dec 2001, Tachino Nobuhiro wrote:
> >
> > But my patch fixes another bug. Current /dev/ram* does not return -ENOSPC
> > at the end of device size because generic_file_write() also checks whether
> > mapping->host is a block device. So I think the patch is required.
> 
> I'll agree with your one-liner: it's good practice anyway to initialize
> any fields that could ever be looked at. I actually already applied it to
> my tree, I just want to make sure that people don't apply the other
> patch..
> 
> 		Linus

Thank you.

I think the patch should be applied to 2.4 because "dd if=/dev/zero of=/dev/ram1"
can cause system hang easily.
Marcelo, please consider applying the patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/