Date:   Sat, 11 Mar 2023 14:05:12 -0500
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2] iio: dac: cio-dac: Migrate to the regmap API
Message-ID: <ZAzQ6LyfllSjN16j@fedora>
References: <20230311140218.74920-1-william.gray@linaro.org>
 <20230311185719.7af38a8a@jic23-huawei>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gdSAI13kS9LQ1z0A"
Content-Disposition: inline
In-Reply-To: <20230311185719.7af38a8a@jic23-huawei>
Precedence: bulk


--gdSAI13kS9LQ1z0A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 11, 2023 at 06:57:19PM +0000, Jonathan Cameron wrote:
> On Sat, 11 Mar 2023 09:02:18 -0500
> William Breathitt Gray <william.gray@linaro.org> wrote:
> > diff --git a/drivers/iio/dac/cio-dac.c b/drivers/iio/dac/cio-dac.c
> > index 791dd999cf29..759833a6bd29 100644
> > --- a/drivers/iio/dac/cio-dac.c
> > +++ b/drivers/iio/dac/cio-dac.c
> > @@ -6,16 +6,15 @@
> >   * This driver supports the following Measurement Computing devices: C=
IO-DAC16,
> >   * CIO-DAC06, and PC104-DAC06.
> >   */
> > -#include <linux/bitops.h>
> > +#include <linux/bits.h>
>=20
> I'm not immediately spotting why this change is part of the regmap
> conversion.
>=20
> It may well make sense, but if unrelated, should probably be in a differe=
nt patch.

No you're right, this is an unrelated cleanup that I should probably
have pulled out to its own dedicated patch. If there is a need for a v3,
I'll split this off and submit it separately.

William Breathitt Gray

--gdSAI13kS9LQ1z0A
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZAzQ6AAKCRC1SFbKvhIj
KxfEAQC3HNpmFWAkWMGkhGrkKmzcQxNcUC1NNFwA3SJHUyAqDgEAlgvrzVmYbfQY
dx/LDVo9zCyk6h39l2Ys4VwxSnM5Fg4=
=OXGt
-----END PGP SIGNATURE-----

--gdSAI13kS9LQ1z0A--