Date:   Sat, 11 Mar 2023 19:38:51 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Svyatoslav Ryhel <clamor95@gmail.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] iio: light: move apds990x into proper place
Message-ID: <20230311193851.42132faf@jic23-huawei>
In-Reply-To: <20230308090219.12710-5-clamor95@gmail.com>
References: <20230308090219.12710-1-clamor95@gmail.com>
        <20230308090219.12710-5-clamor95@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed,  8 Mar 2023 11:02:19 +0200
Svyatoslav Ryhel <clamor95@gmail.com> wrote:

> Since now apds990x supports IIO, it should be moved here from
> misc folder.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>

Hi Svyatoslav,

Could you do me a favour and reply to this thread with a copy of the
.c file that is being moved.

We will want to treat this in a similar fashion to as driver graduating
from staging and do a full review of whether it is compliant with IIO ABI
and general code style etc.  That's easier to do if everyone can
see the code in an email for reviewing!

Thanks,

Jonathan


> ---
>  drivers/iio/light/Kconfig              | 10 ++++++++++
>  drivers/iio/light/Makefile             |  1 +
>  drivers/{misc => iio/light}/apds990x.c |  0
>  drivers/misc/Kconfig                   | 10 ----------
>  drivers/misc/Makefile                  |  1 -
>  5 files changed, 11 insertions(+), 11 deletions(-)
>  rename drivers/{misc => iio/light}/apds990x.c (100%)
> 
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index 0d4447df7200..49c17eb72c73 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -73,6 +73,16 @@ config APDS9300
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called apds9300.
>  
> +config APDS990X
> +	tristate "APDS990X combined als and proximity sensors"
> +	depends on I2C
> +	help
> +	   Say Y here if you want to build a driver for Avago APDS990x
> +	   combined ambient light and proximity sensor chip.
> +
> +	   To compile this driver as a module, choose M here: the
> +	   module will be called apds990x. If unsure, say N here.
> +
>  config APDS9960
>  	tristate "Avago APDS9960 gesture/RGB/ALS/proximity sensor"
>  	select REGMAP_I2C
> diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile
> index 6f23817fae6f..f1ff7934318b 100644
> --- a/drivers/iio/light/Makefile
> +++ b/drivers/iio/light/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_ADUX1020)		+= adux1020.o
>  obj-$(CONFIG_AL3010)		+= al3010.o
>  obj-$(CONFIG_AL3320A)		+= al3320a.o
>  obj-$(CONFIG_APDS9300)		+= apds9300.o
> +obj-$(CONFIG_APDS990X)		+= apds990x.o
>  obj-$(CONFIG_APDS9960)		+= apds9960.o
>  obj-$(CONFIG_AS73211)		+= as73211.o
>  obj-$(CONFIG_BH1750)		+= bh1750.o
> diff --git a/drivers/misc/apds990x.c b/drivers/iio/light/apds990x.c
> similarity index 100%
> rename from drivers/misc/apds990x.c
> rename to drivers/iio/light/apds990x.c
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 9947b7892bd5..2856b6c57ca0 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -359,16 +359,6 @@ config SENSORS_BH1770
>  	   To compile this driver as a module, choose M here: the
>  	   module will be called bh1770glc. If unsure, say N here.
>  
> -config SENSORS_APDS990X
> -	 tristate "APDS990X combined als and proximity sensors"
> -	 depends on I2C
> -	help
> -	   Say Y here if you want to build a driver for Avago APDS990x
> -	   combined ambient light and proximity sensor chip.
> -
> -	   To compile this driver as a module, choose M here: the
> -	   module will be called apds990x. If unsure, say N here.
> -
>  config HMC6352
>  	tristate "Honeywell HMC6352 compass"
>  	depends on I2C
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index 87b54a4a4422..3e3e510cb315 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -18,7 +18,6 @@ obj-$(CONFIG_PHANTOM)		+= phantom.o
>  obj-$(CONFIG_QCOM_COINCELL)	+= qcom-coincell.o
>  obj-$(CONFIG_QCOM_FASTRPC)	+= fastrpc.o
>  obj-$(CONFIG_SENSORS_BH1770)	+= bh1770glc.o
> -obj-$(CONFIG_SENSORS_APDS990X)	+= apds990x.o
>  obj-$(CONFIG_ENCLOSURE_SERVICES) += enclosure.o
>  obj-$(CONFIG_KGDB_TESTS)	+= kgdbts.o
>  obj-$(CONFIG_SGI_XP)		+= sgi-xp/