Subject: Re: [PATCH 11/32] parport_pc: add 16-bit and 8-bit fast EPP transfer
 flags
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
To:     Ondrej Zary <linux@zary.sk>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>
CC:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tim Waugh <tim@cyberelk.net>, <linux-block@vger.kernel.org>,
        <linux-parport@lists.infradead.org>, <linux-ide@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230307224627.28011-1-linux@zary.sk>
 <20230307224627.28011-12-linux@zary.sk>
 <460ae7d7-a12d-cef3-4343-ac633e15016f@omp.ru>
Organization: Open Mobile Platform
Message-ID: <6933a0fe-012d-d0e4-78e5-e651ab5f80a0@omp.ru>
Date:   Sat, 11 Mar 2023 23:31:47 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <460ae7d7-a12d-cef3-4343-ac633e15016f@omp.ru>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 3/11/2023 6:14:00 PM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/11/23 11:09 PM, Sergey Shtylyov wrote:

>> PARPORT_EPP_FAST flag currently uses 32-bit I/O port access for data
>> read/write (insl/outsl).
>> Add PARPORT_EPP_FAST_16 and PARPORT_EPP_FAST_8 that use insw/outsw
>> and insb/outsb (and PARPORT_EPP_FAST_32 as alias for PARPORT_EPP_FAST).
>>
>> Signed-off-by: Ondrej Zary <linux@zary.sk>
>> ---
>>  drivers/parport/parport_pc.c | 20 ++++++++++++++++----
>>  include/uapi/linux/parport.h |  3 +++
>>  2 files changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
>> index 5784dc20fb38..eda4e4e6d4e8 100644
>> --- a/drivers/parport/parport_pc.c
>> +++ b/drivers/parport/parport_pc.c
>> @@ -298,9 +298,15 @@ static size_t parport_pc_epp_read_data(struct parport *port, void *buf,
>>  		}
>>  		return got;
>>  	}
>> -	if ((flags & PARPORT_EPP_FAST) && (length > 1)) {
>> -		if (!(((long)buf | length) & 0x03))
>> +	if ((length > 1) && ((flags & PARPORT_EPP_FAST_32)
>> +			   || flags & PARPORT_EPP_FAST_16
>> +			   || flags & PARPORT_EPP_FAST_8)) {
> 
>    Why not:
> 
>> +		if ((flags & PARPORT_EPP_FAST_32)
>> +		    && !(((long)buf | length) & 0x03))
>>  			insl(EPPDATA(port), buf, (length >> 2));
>> +		else if ((flags & PARPORT_EPP_FAST_16)
>> +			 && !(((long)buf | length) & 0x01))
>> +			insw(EPPDATA(port), buf, length >> 1);
>>  		else
>>  			insb(EPPDATA(port), buf, length);
>

   Oopsie, s/th went wrong while editing... :-/

[...]

MBR, Sergey