From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     Jeff Layton <jlayton@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        coverity-bot <keescook@chromium.org>,
        "yzaikin@google.com" <yzaikin@google.com>,
        "j.granados@samsung.com" <j.granados@samsung.com>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/5] sunrpc: simplify two-level sysctl registration for
 tsvcrdma_parm_table
Thread-Topic: [PATCH v3 1/5] sunrpc: simplify two-level sysctl registration
 for tsvcrdma_parm_table
Thread-Index: AQHZVHLGOAymYSEdgkSmy/EIgUHcZq72VNaAgAACmYCAAAHxAA==
Date:   Sun, 12 Mar 2023 01:22:40 +0000
Message-ID: <CFC1180E-DA7B-45AA-8FE5-77A9A397BBFD@oracle.com>
References: <20230311233944.354858-1-mcgrof@kernel.org>
 <20230311233944.354858-2-mcgrof@kernel.org>
 <724097B6-49DD-437E-9273-5BE40C22C3ED@oracle.com>
 <ZA0nvzJuWYPNLR/c@bombadil.infradead.org>
In-Reply-To: <ZA0nvzJuWYPNLR/c@bombadil.infradead.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HcJWWTeKsGjP6pZ2IC3D/Ol3xmTyuXDlMcFj38kphTkLyW8qYyGVN7Z7KJGM?=
 =?us-ascii?Q?kvh/lG28iNL2YTZvGNo9gEBTJOX6r28j0NKBu10vvFBiGhcEAIGlJXCM02ko?=
 =?us-ascii?Q?dN18rEPktoHybG3pOetr6xfxc++pyx8iOB+lIzTsSPpk1tjQrnZBxo7uE+GH?=
 =?us-ascii?Q?RrmaF98tazZ1/sFaQ++3Kq9MO34GFswzslwtNvQ5CshBNaHCaOIf4eL/UbcN?=
 =?us-ascii?Q?d9rU2F4YaKUbParlMOzNbz5QO3mIHrw+G8Ls7vEs3JxD8OOTfq9gNGJsZvrB?=
 =?us-ascii?Q?TXTdIDiZgo1Uu3SgEk8P2XBMNSFoO4ax0vrxVwhh5jRqAdq8S2BRB+pfb84t?=
 =?us-ascii?Q?SSJG6ngeVS0z0rkbK9Ry1ZDv/MjRcyVidf8BiD747rzfe8he752W1j5dCQx+?=
 =?us-ascii?Q?Akgy76F0FDpRornL50apB2k34pAt+1aseWIj4jwZHUruwd25KEXyUliRGaW7?=
 =?us-ascii?Q?0xS8iGk/PMyX6FzVzVBbgvCD9aWsUcZnfuwAH/nuiskqS6eJg/rQt0rOm7r0?=
 =?us-ascii?Q?OUdNjmaj1X09qfGgZIVqrOF64YEWSSQTX0/tlLBQ7wF8/n4nkqUTq1PoaYW5?=
 =?us-ascii?Q?CoAapUwvcudZWLuYH+ovx+EJST/7HzjjQmxOcLYogReNkpzx9PrYcJzCYGG8?=
 =?us-ascii?Q?cepuPtfnQ1V2gBUyqGusmwtvQ2T7X7Zvva7Nk1QBSXfv79bXNBrWX1wIahFe?=
 =?us-ascii?Q?fIKvdM4LGgnaw5eegmzlXHTWg/aYt+cmNsTitqJopCwEQ7x+NIm+6enZdVP1?=
 =?us-ascii?Q?BCh/7ZNeYxz2ciWURKFULtzgD2PnMau8ceneA58SIVao6wCJ0RyLEOVHy2FS?=
 =?us-ascii?Q?IiYxeHe8VJjIVm3CjacA0QA4kxb7f04Y1Jzw/zX7cfcP3wHkOU3beZy0fvC8?=
 =?us-ascii?Q?AtJLuAtUFAua5MnB83k7kmrBZHYQQzv7IkN7P4c1UAzfWH2l+U4LIdSlG5ng?=
 =?us-ascii?Q?/3ANvx6iIxwSgg5DwiY+k7B1Fj4SFAOVaZ/qmZwoSeJcQ3myyrtCvYTIHUEP?=
 =?us-ascii?Q?GaDX+VfRqb4FiswMbxQKWXIkDQ9KLJwTFMae6IKSfvGO/3Z7D+cyhNjk9156?=
 =?us-ascii?Q?VTNHqjyzE/xIjnIuRUUYajzGl/zZeTQU1gkwHqxPW3Gjc/K360vvLWgJtJx2?=
 =?us-ascii?Q?LsV29CR62oghEdO2EO4i/oDz3SqcmI+0WuvOpjr28EfCipfP87Y2brAAs8S1?=
 =?us-ascii?Q?55z1mS8F0J5zBeFKUStpJu22oMslWYD3gooyrEzC48KrA0DQfecgqoY6QDj0?=
 =?us-ascii?Q?6FYoOaXR4MudipKtyajLInapVybquC24KnTWBvO1t9ciY7IMBp8mQRwhdui/?=
 =?us-ascii?Q?01Hy1YJOXikd3ARq9QbaERaQ1pqzr2sFLodkPdol4akSJWzAFkTm7ek+6gk5?=
 =?us-ascii?Q?lMsWZd8xlgkaSG41LAoHdyiTbnzMAIxncK+qQJBfeyoWDCD+avKwbFB06fDY?=
 =?us-ascii?Q?1j8dq65Fswq+8ZMLeBsF13gXyQW77HT6Y+CZj6zww13/KtXox3Mfx92j/kBD?=
 =?us-ascii?Q?B6rtfJ66JL6VHN0aXjO7O+shWAg2QM7lVkgNPd9kSJhH/bDd+LddFD82GBJd?=
 =?us-ascii?Q?YHjoLkPHOi6ERr2a52Ej6fCdgKmL6l7WEkpTwf62FocvvjgwsbZg4Ow9g+qN?=
 =?us-ascii?Q?SA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1629A09F9639DB4C8E7C178C99EBB685@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?HCVY8utMHbz56cucNnUml67UTwLZkKrA26/d1v53DmeqiWeRJLETxDrpMcD5?=
 =?us-ascii?Q?ITEfXLdOUfTFIJvPDFNqrWNHnZFVfteeobn021DE5S40xaij6yiMrhZAraGK?=
 =?us-ascii?Q?6eo61MP7nKKu1Uhv1emkFdLdAuCa2EEWxHneUH36mzwegOfKqstqTynIkKBt?=
 =?us-ascii?Q?c9er1crqxcOxQb88eoFjVPH0tgN5rRMIKph8YVBL+2Z9YJjYzlH4AEhddAMY?=
 =?us-ascii?Q?EXn1eWoc71VOLx4sszFyPUdhHbZEjWHpMInyZFc76bG/gdgIVL3cI+tXhm6N?=
 =?us-ascii?Q?PAdvQzkdt+Ma8WEfAIgnCbwJkBEaPxHsYLQ91vksNR1xeQCbpUgStpzlUNnn?=
 =?us-ascii?Q?TDUCyhdCnVz89vKpyUlMInrV5zLK0wtCb8BBCMAJWvgqvM92jJ0a9SBYfyvU?=
 =?us-ascii?Q?FeDPhBp0zfAat8sNRenTUi4uRY6gRyaZmk/1rUdYqL/8sVqcc64oLqSPs1AJ?=
 =?us-ascii?Q?t8zVvIiHlAN3+QQ/7O53ihlVTUdwRXTzIE+oLggNW9n3tCD0ZZQy5Lz/e+AP?=
 =?us-ascii?Q?XTutPkpHkqlDn97aDL2AajnrKGn4+BulwtNaZRpNjDsnkRb9NwfmrGsWw+Y3?=
 =?us-ascii?Q?Pg7DEcbYnOUSXIS/dq25RJgyeHZUPr7FIzjTjmGTNHuW3U4tZDwTiOFvfcBD?=
 =?us-ascii?Q?z3UimHf+ugxvJFcmFaZY2OavU6zwmsMUIk+HCjkqeCaRTbwAcH5a/EQ5TE1o?=
 =?us-ascii?Q?fvT1l1sXDZEmLHhgANBXiL4Fhxl+AlNYuF1awb8+BRiMOmdXb5NaEFeqD/mA?=
 =?us-ascii?Q?Hqq+8k5GfSLjlc0tuUfJT3RuIcPe24DbrGETKo14rG8fDvuqvA+BFlrj6tMf?=
 =?us-ascii?Q?mHzEMRnQ/un7N754bguaUkUAg/NMHDtCWHHYaxc8UNWjU+la/Yuv5q/yF2vt?=
 =?us-ascii?Q?8hbjD5TmLO8H2ljNqsRZxbC2FHDHobudEv+odyae4lU7KMINV14ZxkQJt8bS?=
 =?us-ascii?Q?cob49CG43vHQIZxyJIurPvhzPHOtw/wfg8MjH8dLRrv1kTqk0UVkbyEh9Ens?=
 =?us-ascii?Q?7vYsJiwzqtenMdXvzdVasR7jcXH55n3BlYUB8u54SG1mLLNP2QvJqPQ4ZRCb?=
 =?us-ascii?Q?Z96nxqTJ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5134.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b658ea69-797f-420d-6d81-08db229845df
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2023 01:22:40.5544
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0Zdx64Tm93xpNCQLS7qdS5XUliRnO7U5+AUaVRXNq5apSIdy8JioUK9bd4wlsP14fXXN1V44gzt4P9wLhrwGbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5767
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-11_04,2023-03-10_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2303120009
X-Proofpoint-ORIG-GUID: 9AWcB4CXBRPXp89l4yQe1KwXKGJgr9bL
X-Proofpoint-GUID: 9AWcB4CXBRPXp89l4yQe1KwXKGJgr9bL
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 11, 2023, at 8:15 PM, Luis Chamberlain <mcgrof@kernel.org> wrote:
>=20
> On Sun, Mar 12, 2023 at 01:06:26AM +0000, Chuck Lever III wrote:
>>=20
>>=20
>>> On Mar 11, 2023, at 6:39 PM, Luis Chamberlain <mcgrof@kernel.org> wrote=
:
>>>=20
>>> There is no need to declare two tables to just create directories,
>>> this can be easily be done with a prefix path with register_sysctl().
>>>=20
>>> Simplify this registration.
>>>=20
>>> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
>>=20
>> I can take this one, but I'm wondering what "tsvcrdma_parm_table"
>> is (see the short description).
>=20
> Heh sorry                                     tsvcrdma_parm_table was
> supposed to be                                 svcrdma_parm_table.
>=20
> Sorry for the typo.
>=20
> Can you fix or wuold you like me to resend?

I'll fix it up, just wanted confirmation that I wasn't missing
something important!

--
Chuck Lever