Message-ID: <1e8d503d-decb-e662-3457-19d41c6769e0@gmail.com>
Date:   Sun, 12 Mar 2023 15:39:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] staging: greybus: eclose macro in a do - while loop
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Dan Carpenter <error27@gmail.com>, outreachy@lists.linux.dev,
        pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
        gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20230311135919.9129-1-eng.mennamahmoud.mm@gmail.com>
 <10d2c15b-ff9f-4634-a013-7640c93435a7@kili.mountain>
 <c9ae27dc-3538-5432-6a6d-3e2ff034f467@gmail.com>
 <alpine.DEB.2.22.394.2303111600330.2802@hadrien>
Content-Language: en-US
From:   Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
In-Reply-To: <alpine.DEB.2.22.394.2303111600330.2802@hadrien>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On ١١‏/٣‏/٢٠٢٣ ١٧:٠٠, Julia Lawall wrote:
>
> On Sat, 11 Mar 2023, Menna Mahmoud wrote:
>
>> On ١١/٣/٢٠٢٣ ١٦:٠٦, Dan Carpenter wrote:
>>> On Sat, Mar 11, 2023 at 03:59:19PM +0200, Menna Mahmoud wrote:
>>>> " ERROR: Macros with multiple statements should be enclosed in a do -
>>>> while loop"
>>>>
>>>> Reported by checkpath.
>>>>
>>>> do loop with the conditional expression set to a constant
>>>> value of zero (0).This creates a loop that
>>>> will execute exactly one time.This is a coding idiom that
>>>> allows a multi-line macro to be used anywhere
>>>> that a single statement can be used.
>>>>
>>>> So, enclose `gb_loopback_stats_attrs` macro in do - while (0) to
>>>> fix checkpath error
>>>>
>>>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>>>> ---
>>> This breaks the build.  You need to compile the code before sending a
>>> patch.
>>>
>>> regards,
>>> dan carpenter
>>
>> I see, I thought building the file only enough. appreciate your feedback.
> The outreachy tutorial explains how to compile everything in a
> subdirectory.
>
> julia


Thanks Julia, I will check it.

Menna