Date:   Sun, 12 Mar 2023 13:40:18 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Paran Lee <p4ranlee@gmail.com>
Cc:     Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Anton Blanchard <anton@ozlabs.org>,
        Daniel Axtens <dja@axtens.net>,
        Michael Ellerman <mpe@ellerman.id.au>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org
Subject: Re: [RESEND PATCH] perf tools riscv: Add support for riscv
 lookup_binutils_path
Message-ID: <972fcc78-517b-40fa-b46a-ce5dd6f8e980@spud>
References: <20230312130303.87954-1-p4ranlee@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="5/FZjlJfVq2Ptchx"
Content-Disposition: inline
In-Reply-To: <20230312130303.87954-1-p4ranlee@gmail.com>
Precedence: bulk


--5/FZjlJfVq2Ptchx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 12, 2023 at 10:03:05PM +0900, Paran Lee wrote:
> Add to know RISC-V binutils path.
>=20
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> ---
>  tools/perf/arch/common.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>=20
> diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> index 59dd875fd5e4..6ac7a22244c0 100644
> --- a/tools/perf/arch/common.c
> +++ b/tools/perf/arch/common.c
> @@ -43,6 +43,20 @@ const char *const powerpc_triplets[] =3D {
>  	NULL
>  };
> =20
> +const char *const riscv32_triplets[] =3D {
> +	"riscv32-unknown-linux-gnu-",
> +	"riscv32-linux-android-",
> +	"riscv32-linux-gnu-",
> +	NULL
> +};
> +
> +const char *const riscv64_triplets[] =3D {
> +	"riscv64-unknown-linux-gnu-",
> +	"riscv64-linux-android-",
> +	"riscv64-linux-gnu-",

I don't know anything about perf, so I could be asking a really silly
question here, but how come riscvN-linux- has been omitted here?
The kernel.org toolchains [1] are prefixed that way, although I noticed
in your v1 that you'd seemingly duplicated the arm64 patterns, so I am
curious as to whether the omission is intentional.

Cheers,
Conor.

[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/

> +	NULL
> +};
> +
>  const char *const s390_triplets[] =3D {
>  	"s390-ibm-linux-",
>  	"s390x-linux-gnu-",
> @@ -168,6 +182,10 @@ static int perf_env__lookup_binutils_path(struct per=
f_env *env,
>  		path_list =3D powerpc_triplets;
>  	else if (!strcmp(arch, "sh"))
>  		path_list =3D sh_triplets;
> +	else if (!strcmp(arch, "riscv32"))
> +		path_list =3D riscv32_triplets;
> +	else if (!strcmp(arch, "riscv64"))
> +		path_list =3D riscv64_triplets;
>  	else if (!strcmp(arch, "s390"))
>  		path_list =3D s390_triplets;
>  	else if (!strcmp(arch, "sparc"))
> --=20
> 2.34.1
>=20

--5/FZjlJfVq2Ptchx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZA3WPwAKCRB4tDGHoIJi
0sdJAQCoa+n+1sORACKtBGf6R1h/ZsaFTKclg0mcHVus8Gc65AEA9FeWMCtsjgc+
UDqGOtpYMTAQ6x/ALdE8HA8PFZ1T1Q8=
=Lmym
-----END PGP SIGNATURE-----

--5/FZjlJfVq2Ptchx--