Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S285067AbRLLDZj>; Tue, 11 Dec 2001 22:25:39 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S285068AbRLLDZ3>; Tue, 11 Dec 2001 22:25:29 -0500
Received: from ikura.fe.dis.titech.ac.jp ([131.112.171.65]:21379 "HELO
	ikura.fe.dis.titech.ac.jp") by vger.kernel.org with SMTP
	id <S285067AbRLLDZR>; Tue, 11 Dec 2001 22:25:17 -0500
Date: Wed, 12 Dec 2001 12:25:12 +0900
Message-ID: <w53lmg9glwn.wl@megaela.fe.dis.titech.ac.jp>
From: GOTO Masanori <gotom@debian.org>
To: tachino@open.nm.fujitsu.co.jp
Cc: torvalds@transmeta.com, marcelo@conectiva.com.br, gotom@debian.org,
        linux-kernel@vger.kernel.org, andrea@suse.de
Subject: Re: [PATCH] direct IO breaks root filesystem
In-Reply-To: In your message of "Wed, 12 Dec 2001 11:46:29 +0900"
	<wuzt40l6.wl@nisaaru.dvs.cs.fujitsu.co.jp>
In-Reply-To: <y9k945x1.wl@nisaaru.dvs.cs.fujitsu.co.jp>
	<Pine.LNX.4.33.0112111742001.18126-100000@penguin.transmeta.com>
	<wuzt40l6.wl@nisaaru.dvs.cs.fujitsu.co.jp>
User-Agent: Wanderlust/2.2.15 (More Than Words) EMIKO/1.13.9 (Euglena tripteris) FLIM/1.13.2 (Kasanui) APEL/10.2 MULE XEmacs/21.1 (patch 10) (Capitol Reef) (i386-debian-linux)
MIME-Version: 1.0 (generated by EMIKO 1.13.9 - "Euglena tripteris")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 12 Dec 2001 11:46:29 +0900,
Tachino Nobuhiro <tachino@open.nm.fujitsu.co.jp> wrote:
> At Tue, 11 Dec 2001 17:46:01 -0800 (PST),
> Linus Torvalds wrote:
> > 
> > 
> > On Wed, 12 Dec 2001, Tachino Nobuhiro wrote:
> > >
> > > But my patch fixes another bug. Current /dev/ram* does not return -ENOSPC
> > > at the end of device size because generic_file_write() also checks whether
> > > mapping->host is a block device. So I think the patch is required.
> > 
> > I'll agree with your one-liner: it's good practice anyway to initialize
> > any fields that could ever be looked at. I actually already applied it to
> > my tree, I just want to make sure that people don't apply the other
> > patch..
> > 
> > 		Linus
> 
> Thank you.
> 
> I think the patch should be applied to 2.4 because "dd if=/dev/zero of=/dev/ram1"
> can cause system hang easily.

Linus, Tachino, your patch are both right.
I was not aware mapping inode used block file inode... Umm.

In my test, it works fine for both block device and file, and resolves
"inode->i_dev" and block size problems.
Thank you for your (simple and complete) patch! I'm now happy :)

> Marcelo, please consider applying the patch.

Yes. Would you remove my previous patches and apply these patches ?

Thanks,
-- gotom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/