Date:   Sun, 12 Mar 2023 16:55:50 +0100
From:   Lukasz Majewski <lukma@denx.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>, Russell King <linux@armlinux.org.uk>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] dsa: marvell: Provide per device information about
 max frame size
Message-ID: <20230312165550.6349a400@wsk>
In-Reply-To: <20230310154511.yqf3ykknnwe22b77@skbuf>
References: <20230309125421.3900962-1-lukma@denx.de>
        <20230309125421.3900962-2-lukma@denx.de>
        <20230310120235.2cjxauvqxyei45li@skbuf>
        <20230310141719.7f691b45@wsk>
        <20230310154511.yqf3ykknnwe22b77@skbuf>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/EGWCjRQQoH.Nw0G8E.7IoZ9";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/EGWCjRQQoH.Nw0G8E.7IoZ9
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Vladimir,

> On Fri, Mar 10, 2023 at 02:17:19PM +0100, Lukasz Majewski wrote:
> > This is the "patch 4" in the comment sent by Russel (to fix stuff
> > which is already broken, but it has been visible after running the
> > validation code):
> >=20
> > https://lists.openwall.net/netdev/2023/03/09/233 =20
>=20
> Ok, so nope, what I was talking about here (MTU 1492) is *not* what
> you have discussed with Russell in patch 4.

The patch 4 would be related to mv88e6220 and 6250 only. It would
provide correct size of MTU.

>=20
> What I was talking about is this:
> https://patchwork.kernel.org/project/netdevbpf/patch/20230309125421.39009=
62-2-lukma@denx.de/#25245979
> and Russell now seems to agree with me that it should be addressed
> separately,

Ok.

> and prior to the extra development work done here.
>=20

Why? Up till mine patch set was introduced the problem was unnoticed.
Could this be fixed after it is applied?

> It looks like it will also need a bit of assistance from Andrew to
> untangle whether EDSA_HLEN should be included in the max_mtu
> calculations for some switch families only, rather than for all.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/EGWCjRQQoH.Nw0G8E.7IoZ9
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmQN9gYACgkQAR8vZIA0
zr1J5wf+IQzdbTlYu+ISsB/+nmWexSYlnfWNgOh7E7w4SUiI8nW5vv0SctfHpkFM
uJZABIA3Tt3TIA+J05HEB7AGN+dLhYu5rgFRutsJ77BpYa5I9Ogt/5FJgxRh+DzV
wadbqmkVVUVT8NY76YYlwWYJIRLZRwTsPFVQG2XU1Piori0InrfvnHdRzqFZSBq3
Bn7u2SUCK11woc5U54AHKT6Qv8TNxACMZzFxAZcdrKjF1hLT64ey0h3yZ3mkclbY
9N1n6GxPq8XtY9GDDVB6PG2dfLsXwzb2YMSYek+n0fzQnminnvMZamwXIFjthqCl
gxF5aXbROLYHLSBguHQvC1SD9myF7Q==
=aaIR
-----END PGP SIGNATURE-----

--Sig_/EGWCjRQQoH.Nw0G8E.7IoZ9--