Subject: Re: [PATCH v2 0/4] ACPI: SBS: Fix various issues
From:   Armin Wolf <W_Armin@gmx.de>
To:     rafael@kernel.org, lenb@kernel.org
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230225115144.31212-1-W_Armin@gmx.de>
Message-ID: <d2660362-dc25-e75f-394b-1997bd062933@gmx.de>
Date:   Sun, 12 Mar 2023 18:15:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20230225115144.31212-1-W_Armin@gmx.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
UI-OutboundReport: notjunk:1;M01:P0:xSrQQc2HOUo=;/EybnV2+tZEtmVoq1UExYavqUdM
 KQcdpoPjG9Yzf+yeFw0RwkakIq6zi9wHbG+QsFjD/h1zqY02rgvm6B6pvGX3lwHlgKI5EQv6s
 dSvFoYsLGUf3US+5RE6Wd42ke/1uTnmuxiarmimUAw99onAqboZlaC3sbJv6/hjaQeBc2kvk+
 OjeBCrFgoa2l7MSibvKA4RvCqJ3spAI/98ti+GJSR0lYCusq0wtPyIUCObKKO8ps3s6GkvYl/
 MLqab+bB5KWdZsnMC7HrtjgIOaypqaJK0nX5U8OCxdPZHdU2HqXz7tQchwQ3kmaLYOWuBhzpj
 46TJQy1Bp+VK0KcbyV06TYJ2HgOfz0MTHM/pbkKFNE9UXEp0hW9r28cWFVTCxWgn0E82xLiP0
 KuFniRaKwQeNnIRIZHm4Y/n9DQltu5tTH4UN/BiNtrczcZAX/pykTDD1VytcmieH7tT5PUI7K
 VxGVOAqvyv6w5eFK/F/EYhQ4Z+HQRr8CP0oB9WZOReGh9H/O85prVaBVLaQC3kTyVzvhCBBPb
 k4U/9z98+rEQx1Lyx2hOtPUutwHdHIrnOnA7TbG3XuhgnYHZVGCW5cgc2Q9i6/bN6ACPd2OiV
 JgjF6be5O/A7E2Hzb20CcSHFxsTO1ge9TTisnZXOx6TnS9rl+V52nxMtysRLakLvxfnIE9h0m
 i7CpIgSEYsm5rN5ikmzMxLt9bNx8gsi2L7bxYpRnASJonVMlOFsA+mOBt27TzB1uwaAJN7A6D
 Qr3UnhHGPRc75GODBMgYRcHCbTcfD8JobHeS7x2HmFEP9tZIHnxPZlrScsnCABzh+Cqdh2XfF
 jDAzUrYASI+m4nb5Y87mqA7hNGh3C8Z93OXr+p6M1llxS647TpU76wqiDHUbXGteBrUPzGjrW
 c/IgLom0adpzqFvq1WwdyK5Jou/AxkCdqlPnKlKQ0VdE4mXEVc3YHfsNtFVOp0a1HZEZVGbXN
 Kf81t0B2PuC4mKlrW+Sjd6cvyqU=
Precedence: bulk

Am 25.02.23 um 12:51 schrieb Armin Wolf:

> On my Acer Travelmate 4002WLMi, the system locks up upon
> suspend/shutdown. After a lot of research, it turned out
> that the sbs module was the culprit. The driver would not
> correctly mask out the value used to select a battery using
> the "Smart Battery Selector" (subset of the "Smart Battery Manager").
> This accidentally caused a invalid power source to be selected,
> which was automatically corrected by the selector. Upon
> notifing the host about the corrected power source, some batteries
> would be selected for re-reading, causing a endless loop.
> This would lead to some workqueues filling up, which caused the
> lockup upon suspend/shutdown.
>
> The first three patches fix a stacktrace on module removal caused
> by some locking issues. The last patch finally fixes the
> suspend/shutdown issues.
>
> As a side note: This was the first machine on which i installed Linux,
> to finally fixing this took ~5 years of tinkering.

What is the status of this patchset? Should i use a SRCU notifier chain
for the query notifiers? I would really like to see this getting fixed,
as it prevents me from using linux on this machine.

Armin Wolf

> ---
> Changes in v2:
> - make acpi_ec_add_query_handler() static to fix warning
>
> Armin Wolf (4):
>    ACPI: EC: Add query notifier support
>    ACPI: sbshc: Use ec query notifier call chain
>    ACPI: EC: Make query handlers private
>    ACPI: SBS: Fix handling of Smart Battery Selectors
>
>   drivers/acpi/ec.c       | 44 ++++++++++++++++++++--------------------
>   drivers/acpi/internal.h | 10 ++++-----
>   drivers/acpi/sbs.c      | 27 ++++++++++++++++---------
>   drivers/acpi/sbshc.c    | 45 ++++++++++++++++++++++++++---------------
>   4 files changed, 74 insertions(+), 52 deletions(-)
>
> --
> 2.30.2
>
>