Date:   Sun, 12 Mar 2023 20:02:19 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jason Xing <kerneljasonxing@gmail.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next] net-sysfs: display two backlog queue len
 separately
Message-ID: <ZA4huzYKK/tdT3Ep@corigine.com>
References: <20230311151756.83302-1-kerneljasonxing@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230311151756.83302-1-kerneljasonxing@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?60ktPShV2QQEzNOTX7QIb+MixjqiaX2t1ELBPtdEBeMu8Wl1j37iaMREeQUw?=
 =?us-ascii?Q?oOWuy42ZEUqYrr2LFXgwuOnWP0T1wO7K/M1nIqAT3FpUiKfzaiRONx0luNui?=
 =?us-ascii?Q?w16zKkTH46NXVVDqbVHa9VKQMq5T+a0B3iEejy7VC5aP1e/9BS+Oe5xLx111?=
 =?us-ascii?Q?cPrHgvcmLQVnFo8tXiG7bULpGe7M2P2RkAm7fus//WmJvm4qJ6c7Z2siQL1e?=
 =?us-ascii?Q?1U725zfw1ESCdHUXES5nWr0w2Hs3JaYbNFPhw+VI6YCU7j5VMwLrz5oKH6sP?=
 =?us-ascii?Q?F3/PFGVKTvJgTTAXIqKm1s8/9Xf1Oc763wJN0TPSZV17zsEVEGGDZ3AdbAtP?=
 =?us-ascii?Q?w8Lc0v0OrApI+aw0Tp5LWB0Q8GSS7HKd0HCkcFAeSTYUtuyvfaJ84wJ06C7S?=
 =?us-ascii?Q?hKvma+P1UXkVm4x5rih2ICxSnL3HNDxQ09s8Me6YV+vs88/HDMZ+6YYnbq0N?=
 =?us-ascii?Q?RRFs8Bc9Gi46DkdVCVCynJ1jg4/Nvb1yscV2DunTT35jAZ9uxSkEfsUAdZ6R?=
 =?us-ascii?Q?wZ569BmLsXGPwr5lKCPtjakk4ZSvLy1Q6zMEbvWeh6aPWpmP+S3wadK1kuLG?=
 =?us-ascii?Q?BdTH03COvB90tAh4RBEIMmOhZY7kOh2nBXPjCAFCwZ0bMTqx168PFVGD2+qu?=
 =?us-ascii?Q?bNHLFNfl0kt4B8MmWimH+KeKs0nGslM10E8NNJw5mBFL+2y/qH7kFDE5OYDr?=
 =?us-ascii?Q?roA/yRrBQV5YZyzBUkk5GjV14ZNTCg8QP0b213xSJzh52VDjhAosxwsOsrks?=
 =?us-ascii?Q?daDkPS+M9kil48EtAf1FnVFmjjqiOwwPUsPqM6dXAjvdxnSNXrRM7UbSGrcY?=
 =?us-ascii?Q?cRDnzYYLAI0FWYh/h1EfOG9SK3jfGtEMMgPrA5xLBMTdXeeGi5XvFbN7F+CW?=
 =?us-ascii?Q?/yrSiLTIO0jBmCUVppLHZrVL1+lFrmcItuD60UfgqxYk+VrPfbLUEz/jHWhk?=
 =?us-ascii?Q?sUv8p0jXXVgmS79L1XRgZD3dWwFuknXDejr+lO1P4xBCjc321SfMweDkl/Jx?=
 =?us-ascii?Q?r+ZTprbEP70nKMg82dbSNd0BdcpDKaxyoXctP3pZ/OUX4a2GXmRpetadxUqs?=
 =?us-ascii?Q?gvasHn10u15nZfbHN7I3qCtiiw6djMuhoQ+9a5vHzQuGQOQjiH6xhL6hAJ8X?=
 =?us-ascii?Q?rAGpvvOl487DfhGgXLu9w2w3RyK0lutLk9o/583vouRf9FPzj5om4bn9WC1j?=
 =?us-ascii?Q?GiMk9CkVYzzl+MsQ12YK4jwVmI6gsK4aa1bLnnHpqt76Qt/5EUGwjfTIbt/l?=
 =?us-ascii?Q?fnOjdJbcw1D961PqpMKORxGBz1i2O320bUh0SfYzfGN1xbEpNPBYCEc1COgO?=
 =?us-ascii?Q?6ck6m+MSD5eZnc3I/oab/8CxWkfOTXbbJOHmot9Ihvh5DacTzfXrCNf7w3Xk?=
 =?us-ascii?Q?jAHkgdvo652QTBm0HOAxQ8EE82HK4VJneE82W9cul4u1RCGCJ8z9viKTrSnw?=
 =?us-ascii?Q?WLSGsvOp6cJK4W2l4HLWqaFVOLTkn0IJhWmjfKb65OS1kHWuJnVgHev9e9iQ?=
 =?us-ascii?Q?UeEY+bCvoijlIBBx7Eshm+hw+ZhAvoJJkHNzbfKelFfZ4JzKaTpU1uQru1s4?=
 =?us-ascii?Q?f/UyiFLAnOSGOy4sMYT9M2S5TIsxkZVZCdpXcLzK2KX5cnPtPJ+LwlP4f/3D?=
 =?us-ascii?Q?FeVsQ0nAp0RN2N5j8RfBKdsCfFLU1PetEoOVaym1AzJ/DN8xo1Mx8+TrEB9h?=
 =?us-ascii?Q?cEUa2Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f01c4098-7aae-45fb-7db5-08db232c51b5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2023 19:02:26.1626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uJW9r2YaiFmudA0XH8PrbCGHK4eJAaqmSxPa6cen7R9w18mFa5MQ98mSo4YpxidkvmUQRI9fPuhULL0YI/2pkP/oRpCSriZ7v+K3KsnznHg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR13MB4419
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 11, 2023 at 11:17:56PM +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> Sometimes we need to know which one of backlog queue can be exactly
> long enough to cause some latency when debugging this part is needed.
> Thus, we can then separate the display of both.
> 
> Signed-off-by: Jason Xing <kernelxing@tencent.com>
> ---
>  net/core/net-procfs.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/net/core/net-procfs.c b/net/core/net-procfs.c
> index 1ec23bf8b05c..97a304e1957a 100644
> --- a/net/core/net-procfs.c
> +++ b/net/core/net-procfs.c
> @@ -115,10 +115,14 @@ static int dev_seq_show(struct seq_file *seq, void *v)
>  	return 0;
>  }
>  
> -static u32 softnet_backlog_len(struct softnet_data *sd)
> +static u32 softnet_input_pkt_queue_len(struct softnet_data *sd)
>  {
> -	return skb_queue_len_lockless(&sd->input_pkt_queue) +
> -	       skb_queue_len_lockless(&sd->process_queue);
> +	return skb_queue_len_lockless(&sd->input_pkt_queue);
> +}
> +
> +static u32 softnet_process_queue_len(struct softnet_data *sd)
> +{
> +	return skb_queue_len_lockless(&sd->process_queue);
>  }
>  
>  static struct softnet_data *softnet_get_online(loff_t *pos)
> @@ -169,12 +173,15 @@ static int softnet_seq_show(struct seq_file *seq, void *v)
>  	 * mapping the data a specific CPU
>  	 */
>  	seq_printf(seq,
> -		   "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n",
> +		   "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x "
> +		   "%08x %08x\n",
>  		   sd->processed, sd->dropped, sd->time_squeeze, 0,
>  		   0, 0, 0, 0, /* was fastroute */
>  		   0,	/* was cpu_collision */
>  		   sd->received_rps, flow_limit_count,
> -		   softnet_backlog_len(sd), (int)seq->index);
> +		   0,	/* was len of two backlog queues */
> +		   (int)seq->index,

nit: I think you could avoid this cast by using %llx as the format specifier.

> +		   softnet_input_pkt_queue_len(sd), softnet_process_queue_len(sd));
>  	return 0;
>  }
>  
> -- 
> 2.37.3
>