Date:   Sun, 12 Mar 2023 13:50:07 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Naoya Horiguchi <naoya.horiguchi@nec.com>, <linux-mm@kvack.org>,
        Miaohe Lin <linmiaohe@huawei.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memory-failure: correct HWPOISON_INJECT config
Message-Id: <20230312135007.05a4fcea4d26c698a5d48b43@linux-foundation.org>
In-Reply-To: <20230310133843.76883-1-wangkefeng.wang@huawei.com>
References: <20230310133843.76883-1-wangkefeng.wang@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 10 Mar 2023 21:38:43 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:

> Use IS_ENABLED(CONFIG_HWPOISON_INJECT) to check whether or not to
> enable HWPoison injector module.

This is quite clear from the patch itself.  What is unclear is "why". 
Does it fix a build error?  If so, please describe and add a Fixes: if
appropriate.  Is it just a cleanup?  etcetera.

Thanks.

> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -168,7 +168,7 @@ static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, boo
>  	return true;
>  }
>  
> -#if defined(CONFIG_HWPOISON_INJECT) || defined(CONFIG_HWPOISON_INJECT_MODULE)
> +#if IS_ENABLED(CONFIG_HWPOISON_INJECT)
>  
>  u32 hwpoison_filter_enable = 0;
>  u32 hwpoison_filter_dev_major = ~0U;
> -- 
> 2.35.3