Date:   Sun, 12 Mar 2023 22:40:36 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        arnd@arndb.de, olof@lixom.net, soc@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, marex@denx.de, max.krummenacher@toradex.com,
        leoyang.li@nxp.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Tolino Vison
Message-ID: <20230312224036.37dc4d41@aktux>
In-Reply-To: <1346ce4e-f1fd-1a77-f38e-cd87efc59082@linaro.org>
References: <20230312205236.2281466-1-andreas@kemnade.info>
        <20230312205236.2281466-3-andreas@kemnade.info>
        <1346ce4e-f1fd-1a77-f38e-cd87efc59082@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 12 Mar 2023 22:02:24 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 12/03/2023 21:52, Andreas Kemnade wrote:
> > This adds a devicetree for the Kobo Aura 2 Ebook reader. It is based
> > on boards marked with "37NB-E60Q30+4A3". It is equipped with an i.MX6SL
> > SoC.
> >   
> 
> Thank you for your patch. There is something to discuss/improve.
[...]
> > +	pinctrl_i2c2: i2c2grp {
> > +		fsl,pins = <
> > +			MX6SL_PAD_I2C2_SCL__I2C2_SCL	 0x4001f8b1
> > +			MX6SL_PAD_I2C2_SDA__I2C2_SDA	 0x4001f8b1
> > +		>;
> > +	};
> > +
> > +	pinctrl_i2c2_sleep: i2c2grp-sleep {  
> 
> Shouldn't all groups end with 'grp' suffix? Are you sure this passes
> dtbs_check?
> 
> ...
> 
No problem with dtbs_check. But I will resend with corrected names.

Regards,
Andreas