Message-ID: <26a291d8-49c0-e5af-846b-1e29f8266ba9@infradead.org>
Date:   Sun, 12 Mar 2023 17:29:24 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
From:   Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 2/3] menuconfig: reclaim horizontal space
To:     Alexey Dobriyan <adobriyan@gmail.com>, masahiroy@kernel.org
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230311114248.36587-1-adobriyan@gmail.com>
 <20230311114248.36587-2-adobriyan@gmail.com>
Content-Language: en-US
In-Reply-To: <20230311114248.36587-2-adobriyan@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 3/11/23 03:42, Alexey Dobriyan wrote:
> Draw the menu box from position (0, 2) so that there is less unused
> space available. Horizontal is not _really_ important but on small
> terminals maybe it is.

ISTM that the first sentence goes with patch 3/3. ??

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>  scripts/kconfig/lxdialog/menubox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
> index 5c3addad89b0..5eb67c04821f 100644
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
> @@ -184,7 +184,6 @@ int dialog_menu(const char *title, const char *prompt,
>  		return -ERRDISPLAYTOOSMALL;
>  
>  	height -= 4;
> -	width  -= 5;

How does this work?  In my test patch, I changed 5 to 4 to recover/reclaim the
shadow line.  To my surprise, I don't see any negative issue with this change,
but I am perplexed by it.

Anyway, it worked in my testing.

Tested-by: Randy Dunlap <rdunlap@infradead.org>

>  	menu_height = height - 10;
>  
>  	max_choice = MIN(menu_height, item_count());

Thanks.
-- 
~Randy