MIME-Version: 1.0
References: <20230312233052.21095-1-nunes.erico@gmail.com> <20230312233052.21095-4-nunes.erico@gmail.com>
In-Reply-To: <20230312233052.21095-4-nunes.erico@gmail.com>
From:   Qiang Yu <yuq825@gmail.com>
Date:   Mon, 13 Mar 2023 10:37:54 +0800
Message-ID: <CAKGbVbtMW0xUX2sCRnEzBMMu2WRuin9QsW1D45jFHu2d==nbrw@mail.gmail.com>
Subject: Re: [PATCH 3/3] drm/lima: add show_fdinfo for drm usage stats
To:     Erico Nunes <nunes.erico@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, lima@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 13, 2023 at 7:31=E2=80=AFAM Erico Nunes <nunes.erico@gmail.com>=
 wrote:
>
> This exposes an accumulated active time per client via the fdinfo
> infrastructure per execution engine, following
> Documentation/gpu/drm-usage-stats.rst.
> In lima, the exposed execution engines are gp and pp.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
>  drivers/gpu/drm/lima/lima_drv.c | 31 ++++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_=
drv.c
> index d23c0b77a252..c044a31493a4 100644
> --- a/drivers/gpu/drm/lima/lima_drv.c
> +++ b/drivers/gpu/drm/lima/lima_drv.c
> @@ -261,7 +261,36 @@ static const struct drm_ioctl_desc lima_drm_driver_i=
octls[] =3D {
>         DRM_IOCTL_DEF_DRV(LIMA_CTX_FREE, lima_ioctl_ctx_free, DRM_RENDER_=
ALLOW),
>  };
>
> -DEFINE_DRM_GEM_FOPS(lima_drm_driver_fops);
> +static void lima_drm_driver_show_fdinfo(struct seq_file *m, struct file =
*filp)
> +{
> +       struct drm_file *file =3D filp->private_data;
> +       struct drm_device *dev =3D file->minor->dev;
> +       struct lima_device *ldev =3D dev->dev_private;
Can use to_lima_dev().

> +       struct lima_drm_priv *priv =3D file->driver_priv;
> +       struct lima_ctx_mgr *ctx_mgr =3D &priv->ctx_mgr;
> +       u64 usage[lima_pipe_num];
> +
> +       lima_ctx_mgr_usage(ctx_mgr, usage);
> +
> +       /*
> +        * For a description of the text output format used here, see
> +        * Documentation/gpu/drm-usage-stats.rst.
> +        */
> +       seq_printf(m, "drm-driver:\t%s\n", dev->driver->name);
> +       seq_printf(m, "drm-client-id:\t%u\n", priv->id);
> +       for (int i =3D 0; i < lima_pipe_num; i++) {
> +               struct lima_sched_pipe *pipe =3D &ldev->pipe[i];
> +               struct drm_gpu_scheduler *sched =3D &pipe->base;
> +
> +               seq_printf(m, "drm-engine-%s:\t%llu ns\n", sched->name, u=
sage[i]);
> +       }
> +}
> +
> +static const struct file_operations lima_drm_driver_fops =3D {
> +       .owner =3D THIS_MODULE,
> +       DRM_GEM_FOPS,
> +       .show_fdinfo =3D lima_drm_driver_show_fdinfo,
> +};
>
>  /*
>   * Changelog:
> --
> 2.39.2
>