Date:   Mon, 13 Mar 2023 10:54:25 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Joe Stringer <joe@isovalent.com>, bpf@vger.kernel.org
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        ast@kernel.org, corbet@lwn.net, martin.lau@linux.dev,
        maxtram95@gmail.com
Subject: Re: [PATCH bpf-next v3] docs/bpf: Add LRU internals description and
 graph
Message-ID: <ZA6ecdQl3STWVAH6@debian.me>
References: <20230312190600.324573-1-joe@isovalent.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="/TLMb2wQzVHenkud"
Content-Disposition: inline
In-Reply-To: <20230312190600.324573-1-joe@isovalent.com>
Precedence: bulk


--/TLMb2wQzVHenkud
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 12, 2023 at 12:05:59PM -0700, Joe Stringer wrote:
> +Even if an LRU node may be acquired, maps of type ``BPF_MAP_TYPE_LRU_HAS=
H``
> +may fail to insert the entry into the map if other CPUs are heavily cont=
ending
> +on the global hashmap lock.

"Even if an LRU node can be acquired, ..."

> +
> +This algorithm is described visually in the following diagram. See the
> +description in commit 3a08c2fd7634 ("bpf: LRU List") for a full explanat=
ion of
> +the corresponding operations:
> +
> +.. kernel-figure::  map_lru_hash_update.dot
> +   :alt:    Diagram outlining the LRU eviction steps taken during map up=
date
> +
> +   LRU hash eviction during map update for ``BPF_MAP_TYPE_LRU_HASH`` and
> +   variants
> +
> <snipped> ...
> +The dot file source for the above figure uses internal kernel function n=
ames
> +for the node names in order to make the corresponding logic easier to fi=
nd.

Shouldn't the figure note above be in :alt:?

Otherwise LGTM.

--=20
An old man doll... just what I always wanted! - Clara

--/TLMb2wQzVHenkud
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZA6ebQAKCRD2uYlJVVFO
o6i4AQDDoDu50SECyZ8tCj9UQ5Re9A/ZXIMWk4B2eh4IX+7HFwD9EFtVr2ElHKiq
l5QvSUwTEuKlyXwZaxETArCgEMkVvAw=
=Yi4J
-----END PGP SIGNATURE-----

--/TLMb2wQzVHenkud--