Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3428C6FD19 for ; Mon, 13 Mar 2023 05:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbjCMFK4 (ORCPT ); Mon, 13 Mar 2023 01:10:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjCMFKy (ORCPT ); Mon, 13 Mar 2023 01:10:54 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EE9129402 for ; Sun, 12 Mar 2023 22:10:53 -0700 (PDT) Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PZl6468KJz17KRP; Mon, 13 Mar 2023 13:07:56 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 13 Mar 2023 13:10:50 +0800 Message-ID: <4b11f1e3-48ed-6e26-8330-c3ad40f07c80@huawei.com> Date: Mon, 13 Mar 2023 13:10:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm: memory-failure: correct HWPOISON_INJECT config Content-Language: en-US To: Andrew Morton CC: Naoya Horiguchi , , Miaohe Lin , References: <20230310133843.76883-1-wangkefeng.wang@huawei.com> <20230312135007.05a4fcea4d26c698a5d48b43@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20230312135007.05a4fcea4d26c698a5d48b43@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/13 4:50, Andrew Morton wrote: > On Fri, 10 Mar 2023 21:38:43 +0800 Kefeng Wang wrote: > >> Use IS_ENABLED(CONFIG_HWPOISON_INJECT) to check whether or not to >> enable HWPoison injector module. > > This is quite clear from the patch itself. What is unclear is "why". > Does it fix a build error? If so, please describe and add a Fixes: if > appropriate. Is it just a cleanup? etcetera. oh, it's just a cleanup, I think it is no need to use the word 'correct', will update the subject and change log.