Date:   Mon, 13 Mar 2023 07:46:54 +0200
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
        Sanjay R Mehta <sanju.mehta@amd.com>, anson.tsao@amd.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thunderbolt: Disable interrupt auto clear for rings
Message-ID: <20230313054654.GC62143@black.fi.intel.com>
References: <20230310172050.1394-1-mario.limonciello@amd.com>
 <20230310172050.1394-3-mario.limonciello@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230310172050.1394-3-mario.limonciello@amd.com>
Precedence: bulk

Hi Mario,

On Fri, Mar 10, 2023 at 11:20:50AM -0600, Mario Limonciello wrote:
> When interrupt auto clear is programmed, any read to the interrupt
> status register will clear all interrupts.  If two interrupts have
> come in before one can be serviced then this will cause lost interrupts.
> 
> On AMD USB4 routers this has manifested in odd problems particularly
> with long strings of control tranfers such as reading the DROM via bit
> banging.

Nice catch! Does this mean we can drop [1] now?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git/commit/?h=next&id=8d7f459107f74fbbdde3dd5b3874d2e748cb8a21

I would still like to keep the nice refactor you did for the DROM
parsing, though.