Message-ID: <87r0ttdvmt.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Shengjiu Wang <shengjiu.wang@gmail.com>
Cc:     Shengjiu Wang <shengjiu.wang@nxp.com>, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: soc-pcm: fix hw->formats cleared by soc_pcm_hw_init() for dpcm
In-Reply-To: <CAA+D8AOztY7Qp3hs3OOhKuhCDFzqWjSrk240S0CzLR7cg94GLA@mail.gmail.com>
References: <1678346017-3660-1-git-send-email-shengjiu.wang@nxp.com>
        <875yb5frnl.wl-kuninori.morimoto.gx@renesas.com>
        <CAA+D8AOztY7Qp3hs3OOhKuhCDFzqWjSrk240S0CzLR7cg94GLA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Mon, 13 Mar 2023 06:15:54 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gLpz86Zp+9EDJXWZZYE48lW80uC0040E8Mq11qfb7n+Aavs5XhTd2hi/FJUj?=
 =?us-ascii?Q?taHXCY9OhuIdZcdkPvrEgSc9ISKTGSnWaOBh5QgFQ/+qvQffUolGrN9ghBrS?=
 =?us-ascii?Q?rnBJn67aM0oeyVOgOufweVZbEP/EICB5+rOP6kbvGxo5CrsN91b8T8R9daDb?=
 =?us-ascii?Q?/0CqU/dVNy8ud11Gs4d5uPBIksnhYGvpcsxTYWmipl0dwKguq+pChIsrsvXQ?=
 =?us-ascii?Q?nU0eN7LXTGo2B5mCEg8hhoJHOdp8+fIBq1p+GWU3ZrnNyJ4XSNsx8D7+d3ca?=
 =?us-ascii?Q?RV5Yky1fGjYJzJ8xow1uc7frkidUsGPRKOVroiapuYmxJCfbDgq2OJl/lAFl?=
 =?us-ascii?Q?cCI4bba+PQBhmbxU1YUaSE4fC4EoNq05n2z+JZhDD3i/iRaTtWVxsQv48u8/?=
 =?us-ascii?Q?nTErj5bMpC6HY1Lod9zjGX6aJK1gBHo5NaQCXBqif/csRHH86MdKREC4c/tM?=
 =?us-ascii?Q?LOrTYHPoIUmguQOvO8gjsqCtx0qfqWKCNq5vSZnqK6GcSqCERELAj87Zj78R?=
 =?us-ascii?Q?k6fpYlh2+vJT4aQa6cjfS2zMy8a8BUPHfbKvYG2x9svoU41Cxe5GNX7zJLEG?=
 =?us-ascii?Q?sOmvRIC6Gb5HeJdP7noJO2XiHBKMxH3LcEBa2wNyTi1kKMC9mp0UZ0vjqeWJ?=
 =?us-ascii?Q?XqF73hnPfnlxS0eUt1uwskxbmiCbeLqXpXhqMFS1qMpjAsqsROwmmVi8I0o1?=
 =?us-ascii?Q?TY/IQvKWYlm4VeMaXj28h19GX6+iKgl/vrdV2jho5diewHu39Pzkd90LKefk?=
 =?us-ascii?Q?6X6T1hUgy6IU1JIhHaNyi4uMR1zB7AXXWMjRj/gFmVH1uYQ2E4t3i8Ntg655?=
 =?us-ascii?Q?z1v4A/6qk+Inxk2PHoyIEjFluc+2Fb4fNrG6AjpIHS2Gdw3ngmOxHD08ttUH?=
 =?us-ascii?Q?b9PIGri206CXL3WHI1LMXUuc0CGuPaPw8VqLri3YV0xmoGiWEvRomZbMChv6?=
 =?us-ascii?Q?qwInveqTCycNWc2j/yoOfexUqT8HOKQuM3OjXWzm3L7OjPmJxYwI9DA0m5xw?=
 =?us-ascii?Q?YIKWeelRY+WzQD+W+jUr7K26W/l90e7uquAL6PCmkVouOmdzB4IdftrJ5dJC?=
 =?us-ascii?Q?0LNf/ET1vKBS/d4XmC+43MDo9MpPUiOz7fsmYfWPHiGt9rLf4RbZkEOPhGM2?=
 =?us-ascii?Q?9otQ78QEK/sv97VYXekVwe5tkd9m73qKfZwXDvW0J7fNiyLMq07QwTmPsdio?=
 =?us-ascii?Q?AZgjvBwO5EXciFqmhzWROieGI2iGx3WKYvQ0jpwGwQ1+yIPr4bIP5hs/pLnD?=
 =?us-ascii?Q?ZNcNXuIdu2+VJ67vjT2K4t2Hb2oudH2maS9rD/zRFXeMTn0eIYdCDD2tY3Ip?=
 =?us-ascii?Q?2x38nXOO0i3mIoooKbm80TRz/yMTGyOsbOQ7FJ4esFScl0xQ5UuLjeLxw2TD?=
 =?us-ascii?Q?sQCPVa3E0gASixGYnG+MpjCRJbwaGUsu8uUXRRTLGBcA60pmWHwUoWil+1ip?=
 =?us-ascii?Q?amxV/O2Ft7I4IB5FQXTZ5vl3vKmyev/xvwKs7QIe9ZoLKaARevOXvg/EZGSx?=
 =?us-ascii?Q?R0FKYRpDem88PdgWWav3Ij8A6dHDI+vLtPNwpDAgg2PNNiM2LKtitpDGG+4l?=
 =?us-ascii?Q?NPbvNQmHOtBxJD/tlCR7BYyd5/sVjqMMb2jYYLxdVdPT30oMfnHz3chxJWpf?=
 =?us-ascii?Q?W5dKhoHnqIznfp8YJSAN0QQ=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e87e727-7313-4d06-0f0c-08db238a673a
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 06:15:54.9405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Z23IG6eNC1TC1jGI1YXYtJWZ2xBZAno8Pb4mzEMTvQdMJvi7x1gNTco/DmHpAVbIWZEPvF6AXH9RJfqzWJmQtWarZHqJbUd7cnQjTyOabNkeT38NebUA4MoXXCzSl0B
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYPR01MB8231
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Shengjiu

>     But, it is doing same things under (A), too.
>     Do we need to initialize hw many times ? I'm not sure.
>     Can we simply remove soc_pcm_hw_init() from dpcm_runtime_setup_fe() ?
(snip)
> which only calls soc_pcm_init_runtime_hw() for non dpcm case.
> 
> So the initialization of hw is not many times.
>  
> For dpcm the code here will be skipped. The initialization happens
> only in dpcm_runtime_setup_fe().

Oh I see.
Thank you for clarify it.

Best regards
---
Kuninori Morimoto