Message-ID: <972f5a5f-7bff-5425-c3fb-d842d89897ef@nvidia.com>
Date:   Mon, 13 Mar 2023 15:17:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net-next v6 4/5] ip_tunnel: Preserve pointer const in
 ip_tunnel_info_opts
Content-Language: en-US
To:     Eric Dumazet <edumazet@google.com>
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        roopa@nvidia.com, eng.alaamohamedsoliman.am@gmail.com,
        bigeasy@linutronix.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, gavi@nvidia.com, roid@nvidia.com,
        maord@nvidia.com, saeedm@nvidia.com
References: <20230309134718.306570-1-gavinl@nvidia.com>
 <20230309134718.306570-5-gavinl@nvidia.com>
 <CANn89i+k3fcSw58owpr70eM_uSM5QUqEb_4y5wpXOKEz30+vvg@mail.gmail.com>
 <CANn89iKcDNZBerR_2nEp_ryM3BVXuvr64s6tnAvizCwr=SuACg@mail.gmail.com>
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <CANn89iKcDNZBerR_2nEp_ryM3BVXuvr64s6tnAvizCwr=SuACg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RCt5UkRwV0lWOUc3S2tSNFhobVR5VTlUNEhpdzJZZjdwb1hXODdyOFcweW01?=
 =?utf-8?B?UG8xYU5kKzhhWDg3RWExV21ST0xIUEpvWUloS1JpK1NZKyszL2hCdU5HUTJJ?=
 =?utf-8?B?aTltWnFwT05iTnFuaXhZQ1pNd3AwYTBoWFBjemlSdGVmSndxM1ROSXcwQ1VX?=
 =?utf-8?B?cmMxM0FMZUtXTHdRelllYVQyQ1A5d09CdFB4aUdKdHcraWF2b1RxR0pGMDZr?=
 =?utf-8?B?Yk9tb2VCaTFZbFNiTG8zMm8relpuSldpVnc4VHJpSEVDZXMwcnJOSmtlSitN?=
 =?utf-8?B?cUVidUFOSURQaHdrb3FUOE5IMzAvWTBQSXp5Zk1ucmp4b3ZiMXdkK1MyajJm?=
 =?utf-8?B?akc4MHVRUkVuWHpVZmpHTnF2ZU1WaEt3S2pPamVMWDdiZmZXZmRBL0RLU1VS?=
 =?utf-8?B?emU1SDFtVXJBWU1vdFJIdCs1b3ZvSklJKzdyL245OHNtZGVzSU1XVWZjSnFE?=
 =?utf-8?B?WDdIZE5xeW5ISVMxaW9aSGlMbEwrV0w2K1ErYWNoY2tkc1ozT0RtaUJXU0p0?=
 =?utf-8?B?a1VCeEJnSzltK3ptWFhySGRzS0dDZ0FWQTdwbFhHRzRCRU5uLzRkazAxa3VE?=
 =?utf-8?B?Ry9nVFFYN1BuMWhFSGprcjE3OEN4TTNNZGQwV2RzMG5ONEExakFmL0JRaXd6?=
 =?utf-8?B?aXM1R29DVzhQUWJoSlZGMDNxalFhSmRoS1hpSnRxRXhDa1VSQklGZVpUd3hZ?=
 =?utf-8?B?OG9wc2VhSTVPV04vVWtrOEVzeFR6VysyRmpqUVMrQnJrZW5TeHFTZG1oRFBX?=
 =?utf-8?B?ZzlDL09ub3NRMENDbG9QcFRJNis0NW1KV0FvMFNNSm9yTkQzRm1xNnpVYTRv?=
 =?utf-8?B?UTgycmswN2hObUozMi9jR21MNXF1d3Q0V2pTaWNQWFN3WDRsdjVIZ3NxdUs4?=
 =?utf-8?B?aFIxNERnVFBWZkpXMmxOemd5UHVGNjVCUVFuRGRFQnFCTmJoakoyN0syVDc2?=
 =?utf-8?B?NTJUbG1hZ1RHOFV5Zlc4dklYZHZaaTdBOTB4VDNoV2hBMEMvb1lvaWVsOFdM?=
 =?utf-8?B?V3lkVG5SQy9QYVRVaEJnNUxhQml3bm9BL21VMlBhYnhqU1I4ang3M3RpQk1S?=
 =?utf-8?B?THRkYWE4NXEwamNLTFdrYm1hOG5vQVhIUVFsNm9YWXJSSitNbnBpSTM3YWRM?=
 =?utf-8?B?eHc0ZFkyTWtnV0s1c3RNaW1MQXRyaVAzZXM2N3NoQVZGT3FQb1dNalRSVDl0?=
 =?utf-8?B?SVhRemg1b0wyOWZTTk5NaVZCRjhaRngwMHFFNmZSZVFPZnVoN3h2WjNoMEJO?=
 =?utf-8?B?Mk5vN2gva2xiSUNBUytsUDkzbkwxR2ZwOE5GTXJjd1NMT1lHMVhXM013ZDZw?=
 =?utf-8?B?dkFPQ0kwUm1qRXN6YVlUaW5YZGpzV0ZjamphNVVSTnQxS25vYlJuZ1FLdld0?=
 =?utf-8?B?QUhpZ3V2Q1RIcGhVMW5VYTY2TW9Jb01tTEJMQlNrUjVwaGFYc1JIa2JpSXpx?=
 =?utf-8?B?cHBpQmpScGQ4b1ZVSkUzMG1tVStyWnRiWndwT2VqZnM5T0VWelBTYzlkclhp?=
 =?utf-8?B?ZVBQb3BnUmFyZEJaSHkrNGhBU1RSZFZyRjk5Y1dhb3BseGJGMkxrdkYxTU0x?=
 =?utf-8?B?UEFvWVhZZ1JiMGlFUDg4cDd0QWtvUkFWL0t0aHBqSzFFWkxCd2plcEdJNHVO?=
 =?utf-8?B?Z08wREMxUzlJNzVKU2lGWDFoczk2ODNkTFdYSlExRDdxOGEweWJMdlYrelpT?=
 =?utf-8?B?cnRqOURudlpmSFk4RFliRTNXemhKbVBzbVI5YlFvcDMzWVBPR3JGSHo0aWh6?=
 =?utf-8?B?NXZRMnhqRnZMa1gvSFlZTXJJOTgwVDZmOEh1dVM2RWRoNi94b0hpNkMycTBD?=
 =?utf-8?B?KzQ5ZS9BV1dSeHNYNXFJOXhrR1hldithYjU4dXlCLzlGaXNPbzlUK3AxL2Fx?=
 =?utf-8?B?UVF4Znp5Sk1UWEVNZU9BSFNIYlpDcWxkU29ib1ZRWkxqc2FxMFNoY2xjZ1Mx?=
 =?utf-8?B?UFFGdzd4SFVCbUYrLzZlVFZJYjkydHJYR2gwdFBzYWh5TUk0SlE4ajJ4Nmg4?=
 =?utf-8?B?K1E1VnA2THV4Ylp3MmFReEU3b1pkRU5VUjNFTzMxRUl1V0RmRm9udDFVcyt2?=
 =?utf-8?B?dkJFNTdEbTBlQjNsZXJjYjRpTlF0cUVxNDE3RVowTmRJNmxNeHpsZ2V6WTJT?=
 =?utf-8?Q?lZ9oAsw2eh53r8G9qFI1+0uS9?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 421e660b-ef4b-4d5f-da82-08db23931bc7
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 07:18:14.0835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HWI1sWXKxeaRsCl9lfnRrWUO4qlO1WRsYUx2cHwXSV0VbOlmtLtFOMRNI3JfEgarueQB9xDY2AEbf095BsFLgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8730
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/9/2023 11:05 PM, Eric Dumazet wrote:
> External email: Use caution opening links or attachments
>
>
> On Thu, Mar 9, 2023 at 3:59 PM Eric Dumazet <edumazet@google.com> wrote:
>> On Thu, Mar 9, 2023 at 2:48 PM Gavin Li <gavinl@nvidia.com> wrote:
>>> Change ip_tunnel_info_opts( ) from static function to macro to cast return
>>> value and preserve the const-ness of the pointer.
>>>
>>> Signed-off-by: Gavin Li <gavinl@nvidia.com>
>>> ---
>>>   include/net/ip_tunnels.h | 11 ++++++-----
>>>   1 file changed, 6 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
>>> index fca357679816..3e5c102b841f 100644
>>> --- a/include/net/ip_tunnels.h
>>> +++ b/include/net/ip_tunnels.h
>>> @@ -67,6 +67,12 @@ struct ip_tunnel_key {
>>>          GENMASK((sizeof_field(struct ip_tunnel_info,            \
>>>                                options_len) * BITS_PER_BYTE) - 1, 0)
>>>
>>> +#define ip_tunnel_info_opts(info)                              \
>>> +       _Generic(info,                                          \
>>> +               const typeof(*(info)) * : ((const void *)((info) + 1)),\
>>> +               default : ((void *)((info) + 1))                \
>>> +       )
>>> +
>> Hmm...
>>
>> This looks quite dangerous, we lost type safety with the 'default'
>> case, with all these casts.
>>
>> What about using something cleaner instead ?
>>
>> (Not sure why we do not have an available generic helper for this kind
>> of repetitive things)
>>
> Or more exactly :
>
> diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
> index fca3576798166416982ee6a9100b003810c49830..17fc6c8f7e0b9e5303c1fb9e5dad77c5310e01a9
> 100644
> --- a/include/net/ip_tunnels.h
> +++ b/include/net/ip_tunnels.h
> @@ -485,10 +485,11 @@ static inline void iptunnel_xmit_stats(struct
> net_device *dev, int pkt_len)
>          }
>   }
>
> -static inline void *ip_tunnel_info_opts(struct ip_tunnel_info *info)
> -{
> -       return info + 1;
> -}
> +#define ip_tunnel_info_opts(info)                                      \
> +       (_Generic(info,                                                 \
> +                const struct ip_tunnel_info * : (const void *)((info)
> + 1),    \
> +                struct ip_tunnel_info * : (void *)((info) + 1))        \
> +       )
>
>   static inline void ip_tunnel_info_opts_get(void *to,
>                                             const struct ip_tunnel_info *info)
ACK